Skip to content

Commit

Permalink
style: change CreateUploadLocaltionParam to singular
Browse files Browse the repository at this point in the history
  • Loading branch information
nguyentoanit committed Feb 13, 2021
1 parent 6d195f7 commit 9155e3a
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions src/operations/media/sponsored-brands-media-operation.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Operation } from '../operation'
import { CompleteMediaParam, CreateUploadLocaltionParams, MediaId, UploadLocation } from './types'
import { CompleteMediaParam, CreateUploadLocaltionParam, MediaId, UploadLocation } from './types'
import { Decode } from '../../decorators'

export class SponsoredBrandsMediaOperation extends Operation {
Expand All @@ -13,7 +13,7 @@ export class SponsoredBrandsMediaOperation extends Operation {
* @returns
*/
@Decode(UploadLocation)
public createUploadLocation(param: CreateUploadLocaltionParams) {
public createUploadLocation(param: CreateUploadLocaltionParam) {
return this.client.post<UploadLocation>(`${this.resource}/upload`, param)
}

Expand Down
6 changes: 3 additions & 3 deletions src/operations/media/types.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,23 @@ import * as t from './types'

describe('CreateUploadLocaltionParams', () => {
it('should pass', () => {
const res = t.CreateUploadLocaltionParams.decode({
const res = t.CreateUploadLocaltionParam.decode({
programType: 'SponsoredBrands',
creativeType: 'Video',
})

expect(isRight(res)).toBeTruthy()
})
it('should fail if programType is missing', () => {
const res = t.CreateUploadLocaltionParams.decode({
const res = t.CreateUploadLocaltionParam.decode({
creativeType: 'Video',
})

expect(isRight(res)).toBeFalsy()
})

it('should fail if creativeType is missing', () => {
const res = t.CreateUploadLocaltionParams.decode({
const res = t.CreateUploadLocaltionParam.decode({
programType: 'SponsoredBrands',
})

Expand Down
4 changes: 2 additions & 2 deletions src/operations/media/types.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import * as t from 'io-ts'

export const CreateUploadLocaltionParams = t.strict({
export const CreateUploadLocaltionParam = t.strict({
programType: t.literal('SponsoredBrands'),
creativeType: t.literal('Video'),
})
export type CreateUploadLocaltionParams = t.TypeOf<typeof CreateUploadLocaltionParams>
export type CreateUploadLocaltionParam = t.TypeOf<typeof CreateUploadLocaltionParam>

export const UploadLocation = t.string
export type UploadLocation = t.TypeOf<typeof UploadLocation>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {
CompleteMediaParam,
CreateUploadLocaltionParams,
CreateUploadLocaltionParam,
SponsoredBrandsMediaOperation,
} from '../../../src'
import { OperationProvider } from '../../../src/operations/operation-provider'
Expand All @@ -19,7 +19,7 @@ describe('SponsoredBrandsMediaOperation', () => {
*/
describe.skip('createUploadLocation', () => {
it(`should retrieve a upload location`, async () => {
const param: CreateUploadLocaltionParams = {
const param: CreateUploadLocaltionParam = {
programType: 'SponsoredBrands',
creativeType: 'Video',
}
Expand Down

0 comments on commit 9155e3a

Please sign in to comment.