browser media extensions not populated

[rmuthukrishnan]

Hi, Thank you for providing this configuration file.

In the latest version, I cloned the repository and ran the php script. I see the media extensions is not populated below:

BROWSER MEDIA CACHE

location ~* .()$ {
etag on;
expires 30d;
}

In version 1.1, it is the following:

BROWSER MEDIA CACHE

location ~* .(ico|gif|jpe?g|png|svg|eot|otf|woff|woff2|ttf|ogg)$ {
expires max;
add_header Cache-Control "public";
add_header Access-Control-Allow-Origin "*";
}

Could you check? I see the template file does have the media extensions. I did not modify any of the files.

Thank you,
Raman

[maximejobin]

Did you follow instructions here:
https://github.com/maximejobin/rocket-nginx#installation

My guess is that you did not rename the ini file (removing the .disabled).

Let me know if I was right.

[rmuthukrishnan]

Hi Maxime, Thank you for your response. I did follow the instructions. Copying or moving rocket-nginx.ini.disabled to rocket-nginx.ini gives the same result for me. I found one issue: The rocket-nginx.ini has the key name as media_extensions while the rocket_parser.php had it as medias_extension. I corrected that in rocket_parser.php, but then the check for is_array on that is failing. Raman

…

________________________________ From: Maxime Jobin <[email protected]> Sent: Friday, October 27, 2017 1:30 PM To: maximejobin/rocket-nginx Cc: rmuthukrishnan; Author Subject: Re: [maximejobin/rocket-nginx] browser media extensions not populated (#67) Did you follow instructions here: https://github.com/maximejobin/rocket-nginx#installation My guess is that you did not rename the ini file (removing the .disabled). Let me know if I was right. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#67 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Afm7fBRE6ToXI4HJvNlCPCsPNZkTvL_Lks5swj1zgaJpZM4QIiiX>.

[maximejobin]

I was able to reproduce the problem. A new version will be released.

[maximejobin]

Fixed.