Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for capsule update playbook #15863

Merged
merged 1 commit into from
Oct 24, 2024
Merged

add test for capsule update playbook #15863

merged 1 commit into from
Oct 24, 2024

Conversation

pondrejk
Copy link
Contributor

@pondrejk pondrejk commented Aug 6, 2024

Problem Statement

Adjusting to the recent changes in satellite-maintain, for the test's scenario (upgrade from stream to stream) it no longer makes sense to specify the target version.

Solution

Related Issues

#15862 is also needed to make this work, but that change is meant to be cherrypickes, while this should be master only

@pondrejk pondrejk added the No-CherryPick PR doesnt need CherryPick to previous branches label Aug 6, 2024
@pondrejk pondrejk self-assigned this Aug 6, 2024
@pondrejk pondrejk requested a review from a team as a code owner August 6, 2024 09:08
@pondrejk pondrejk mentioned this pull request Aug 6, 2024
Merged
lpramuk
lpramuk requested changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@lpramuk lpramuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove --target-version completely

tests/foreman/api/test_remoteexecution.py Outdated Show resolved Hide resolved
@pondrejk
Copy link
Contributor Author

pondrejk commented Aug 6, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k capsule

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7990
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_remoteexecution.py -k capsule --external-logging
Test Result : ========== 1 failed, 2 deselected, 16 warnings in 1382.00s (0:23:01) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Aug 6, 2024
@pondrejk
Copy link
Contributor Author

pondrejk commented Aug 6, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k capsule

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7996
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_remoteexecution.py -k capsule --external-logging
Test Result : ========== 1 failed, 2 deselected, 16 warnings in 1458.04s (0:24:18) ===========

lpramuk
lpramuk requested changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@lpramuk lpramuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust job template name as well

tests/foreman/api/test_remoteexecution.py Show resolved Hide resolved
@pondrejk
Copy link
Contributor Author

pondrejk commented Aug 7, 2024 

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k capsule
theforeman:
    foreman_ansible: 727

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8004
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_remoteexecution.py -k capsule --external-logging
Test Result : ========== 1 failed, 2 deselected, 15 warnings in 2675.16s (0:44:35) ===========

@pondrejk
Copy link
Contributor Author

pondrejk commented Aug 8, 2024 

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k capsule
theforeman:
    foreman_ansible: 727

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8020
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_remoteexecution.py -k capsule --external-logging
Test Result : ============ 2 deselected, 8 warnings, 1 error in 291.51s (0:04:51) ============

@pondrejk
Copy link
Contributor Author

pondrejk commented Aug 8, 2024 

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k capsule
theforeman:
    foreman_ansible: 727

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8022
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_remoteexecution.py -k capsule --external-logging
Test Result : ========== 1 passed, 2 deselected, 15 warnings in 2774.65s (0:46:14) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Aug 8, 2024
@pondrejk pondrejk mentioned this pull request Aug 8, 2024
Merged
@Gauravtalreja1 Gauravtalreja1 requested a review from lpramuk August 12, 2024 16:00
@lpramuk
Copy link
Contributor

lpramuk commented Sep 4, 2024 •
edited
Loading

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k capsule

@lpramuk lpramuk added the 6.16.z Introduced in or relating directly to Satellite 6.16 label Sep 4, 2024
@lpramuk lpramuk added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Sep 4, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8461
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_remoteexecution.py -k capsule --external-logging
Test Result : ========== 1 failed, 2 deselected, 15 warnings in 1457.51s (0:24:17) ===========

@Satellite-QE Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Sep 4, 2024
@lpramuk
Copy link
Contributor

lpramuk commented Sep 4, 2024 

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k capsule
env:
    ROBOTTELO_server__version__release: '6.16.0'
    ROBOTTELO_server__version__snap: '2.0'
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16.0'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '2.0'

@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Sep 4, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8468
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_remoteexecution.py -k capsule --external-logging
Test Result : ========== 1 failed, 2 deselected, 15 warnings in 1438.00s (0:23:58) ===========

@pondrejk
Copy link
Contributor Author

pondrejk commented Sep 5, 2024

@lpramuk looking at the prt result I suppose that changes from theforeman/foreman_ansible#727 didn't get to 6.16 build... I'm sure they are not in stream either as the last foreman_ansible plugin release was before it got merged. So I guess we can re-run prt after plugin release and stream delivery happens

@lpramuk
Copy link
Contributor

lpramuk commented Sep 6, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k capsule

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8500
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_remoteexecution.py -k capsule --external-logging
Test Result : ========== 1 failed, 2 deselected, 15 warnings in 2529.89s (0:42:09) ===========

@lpramuk
Copy link
Contributor

lpramuk commented Sep 6, 2024 •
edited
Loading

@pondrejk It is not even in today's stream/6.17 snap

Lets wait with merging for product changes to occur

@pondrejk pondrejk changed the title capsule upgrade playbook -- don't specify target version add test for capsule update playbook Sep 11, 2024
@pondrejk pondrejk mentioned this pull request Sep 11, 2024
Merged
@lhellebr
Copy link
Contributor

So what should happen without target version specified? Update to the latest stream snap? Do you really check somewhere that it has really been updated to the LATEST snap?

@lhellebr
Copy link
Contributor

Also, should it be in the recent snap?

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k capsule

pnovotny
pnovotny approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@pnovotny pnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, PRT pending.

@pondrejk
Copy link
Contributor Author

pondrejk commented Oct 4, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k test_positive_run_capsule_update_playbook

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8868
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_remoteexecution.py -k test_positive_run_capsule_update_playbook --external-logging
Test Result : ========== 1 failed, 3 deselected, 16 warnings in 1609.68s (0:26:49) ===========

@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k test_positive_run_capsule_update_playbook

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9131
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_remoteexecution.py -k test_positive_run_capsule_update_playbook --external-logging
Test Result : ========== 1 passed, 3 deselected, 16 warnings in 1526.59s (0:25:26) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Oct 24, 2024
@pondrejk pondrejk added No-CherryPick PR doesnt need CherryPick to previous branches and removed CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.16.z Introduced in or relating directly to Satellite 6.16 labels Oct 24, 2024
@pondrejk pondrejk merged commit 905c5bf into SatelliteQE:master Oct 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 left review comments

@lpramuk lpramuk lpramuk approved these changes

@pnovotny pnovotny pnovotny approved these changes

Assignees

@pondrejk pondrejk

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pondrejk @Satellite-QE @lpramuk @lhellebr @pnovotny @Gauravtalreja1