remove user to prevent ForeignKeyViolation

tests/foreman/api/test_ansible.py

@@ -21,7 +21,7 @@
 
 
 @pytest.fixture
-def filtered_user(target_sat, module_org, module_location):
+def filtered_user(request, target_sat, module_org, module_location):
     """
     :steps:
         1. Create a role with a host view filtered
@@ -31,6 +31,12 @@ def filtered_user(target_sat, module_org, module_location):
     role = target_sat.api.Role(
         name=gen_string('alpha'), location=[module_location], organization=[module_org]
     ).create()
+    password = gen_string('alpha')
+    user = target_sat.api.User(
+        role=[role], password=password, location=[module_location], organization=[module_org]
+    ).create()
+    if is_open('SAT-18656'):
+        request.addfinalizer(user.delete)
     # assign view_hosts (with a filter, to test BZ 1699188),
     # view_hostgroups, view_facts permissions to the role
     permission_hosts = target_sat.api.Permission().search(query={'search': 'name="view_hosts"'})
@@ -43,12 +49,6 @@ def filtered_user(target_sat, module_org, module_location):
     ).create()
     target_sat.api.Filter(permission=permission_hostgroups, role=role).create()
     target_sat.api.Filter(permission=permission_facts, role=role).create()
-
-    password = gen_string('alpha')
-    user = target_sat.api.User(
-        role=[role], password=password, location=[module_location], organization=[module_org]
-    ).create()
-
     return user, password
 
 
@@ -296,7 +296,6 @@ def test_positive_read_facts_with_filter(
         host.organization = module_org
         host.location = module_location
         host.update(['organization', 'location'])
-
         # gather ansible facts by running ansible roles on the host
         host.play_ansible_roles()
         if is_open('SAT-18656'):