Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove s2id from the locator #1750

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amolpati30
Copy link
Contributor

@amolpati30 amolpati30 commented Feb 25, 2025

Some locators have changed after the jQuery3 update, so update the locators accordingly to ensure the test functions correctly.

@amolpati30 amolpati30 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing Stream 6.17.z labels Feb 25, 2025
@LadislavVasina1 LadislavVasina1 self-requested a review February 25, 2025 07:45
@amolpati30 amolpati30 requested a review from shweta83 February 25, 2025 07:47
@shweta83
Copy link
Contributor

@amolpati30 There are many other occurences of locator which starts with s2id. Are those remain unchanged?

@amolpati30
Copy link
Contributor Author

@amolpati30 There are many other occurences of locator which starts with s2id. Are those remain unchanged?

I have checked for CR only; I will check for the other components as well.

@amolpati30
Copy link
Contributor Author

@amolpati30 There are many other occurences of locator which starts with s2id. Are those remain unchanged?

I have updated the locator for other component.

@amolpati30 amolpati30 force-pushed the update_the_locator branch 4 times, most recently from c59f476 to ab494f7 Compare February 25, 2025 18:20
@amolpati30 amolpati30 changed the title update the locator remove s2id from the locator Feb 25, 2025
@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 25, 2025
@@ -1174,7 +1174,7 @@ def __init__(self, parent, id=None, locator=None, logger=None):

def read(self):
"""Return drop-down selected item value"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amolpati30 Thanks for adding this change. Can you please add a small comment above this line so that anyone who sees the reason of adding it? This is a non-blocker comment.

@shweta83
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_gce.py::test_positive_gce_provision_end_to_end
env:
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.17'

@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_gce.py::test_positive_gce_provision_end_to_end
env:
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.17.0'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '1.1'

@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_ec2.py

1 similar comment
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_ec2.py

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Feb 27, 2025
@amolpati30 amolpati30 requested a review from shweta83 February 27, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.17.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants