fix(loading icon): messageLoading was never being set to false #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybe it was accidentally deleted
stavares843
added
the
Missing Dev Review
josephmcg
commented
Dec 16, 2021
| @@ -223,15 +223,17 @@ export default { | |||
| sender: MessageRouteEnum.OUTBOUND, | |||
| message: result, | |||
| }) | |||
| },/** | |||
| commit('setMessageLoading', { loading: false }) | |||
There was a problem hiding this comment.
mostly prettier formatting, this is my only addition
|
is about that? i thought was on purpose like animation lol π |
stavares843
approved these changes
Dec 16, 2021
stavares843
added
the
QA tested
|
exactly lol |
InfamousVague
approved these changes
Dec 16, 2021
github-actions
bot
removed
Missing Dev Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe it was accidentally deleted
What this PR does π
Which issue(s) this PR fixes π¨
Permanent message loading icon
Fixes #
Special notes for reviewers ποΈ
Additional comments π€