Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat): unblock sending while file upload in progress #4824

Merged
merged 4 commits into from
Sep 16, 2022
Merged

feat(chat): unblock sending while file upload in progress #4824

merged 4 commits into from
Sep 16, 2022

Conversation

josephmcg
Copy link
Contributor

What this PR does 📖

  • move Chatbar uploading local state variable to vuex store.
    • I did this to put the message loader in a different component
    • it also ensures the state is maintained even if chatbar is unmounted
  • display loader if store array contains this conversationId
  • still allow new messages to be sent even if a previous upload is still in progress

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@josephmcg josephmcg linked an issue Sep 15, 2022 that may be closed by this pull request
unblock sending while files are uploading #4823
Closed
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 15, 2022
molimauro
molimauro suggested changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@molimauro molimauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one minor thing

@molimauro molimauro added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Sep 15, 2022
@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Sep 16, 2022
@josephmcg josephmcg force-pushed the 4823-unblock-sending-while-files-are-uploading branch from 9bf9c42 to c5dd479 Compare September 16, 2022 01:10
@josephmcg josephmcg removed the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Sep 16, 2022
@josephmcg josephmcg added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Sep 16, 2022
@aewing aewing merged commit 154c515 into dev Sep 16, 2022
@aewing aewing deleted the 4823-unblock-sending-while-files-are-uploading branch September 16, 2022 01:39
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molimauro molimauro molimauro requested changes

@aewing aewing aewing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unblock sending while files are uploading
3 participants
@josephmcg @aewing @molimauro