Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(conversation): improve hooks to avoid repeated logic #4779

Merged
merged 1 commit into from
Sep 14, 2022
Merged

refactor(conversation): improve hooks to avoid repeated logic #4779

merged 1 commit into from
Sep 14, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Sep 14, 2022 •
edited
Loading

What this PR does 📖

  • no new functionality, just organization and consolidation.
  • add a new hook ( otherTypingParticipants). haven't implemented in a component yet, that will come separately

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

  • Will add typing chat footer after new hook here gets merged

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 14, 2022
nathan-power
nathan-power approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@nathan-power nathan-power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josephmcg josephmcg merged commit 28f3ee9 into dev Sep 14, 2022
@josephmcg josephmcg deleted the conversationHooksRefactor branch September 14, 2022 06:07
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-power nathan-power nathan-power approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephmcg @nathan-power