Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(refactor): pre-launch cleanup, offline sync, reactivity & observable bugfixes, emitter & pubsub bugfixes #4525

Merged
merged 5 commits into from
Aug 30, 2022
Merged

feat(refactor): pre-launch cleanup, offline sync, reactivity & observable bugfixes, emitter & pubsub bugfixes #4525

merged 5 commits into from
Aug 30, 2022

Conversation

aewing
Copy link
Contributor

@aewing aewing commented Aug 29, 2022 •
edited
Loading

What this PR does 📖

  • Fixes multiple subscription handler issue (onSyncSubscribeResponse in ChatManager & WebRTCManager)
  • Fixes multiple emitter handler bug (UserManager.peerSearch)
  • Adds support for new subscribe changes in Iridium (sync & offline sync as options)
  • Add friend by partial, name, name#did.substr(-6)
  • Standardizes approach to reactivity in preparation for moving managers to external package (option to reuse)
  • Removes the WebRTC hooks & moves that logic to manager (so we have the option to reuse it elsewhere, to reduce duplication)
  • Fixes timing issues on startup
  • Fixes & restores lastReadAt
  • Addresses some issues with peer announce
  • Addresses some issues with WebRTC publishing events for every single peer, including all users in usermanager (search result matches)
  • Misc. additional cleanup

@stavares843 stavares843 added the draft A developer wants eyes on this PR, but they don't think it's ready to merge. label Aug 29, 2022
josephmcg
josephmcg suggested changes Aug 30, 2022
View reviewed changes
components/ui/BackgroundCall/BackgroundCall.vue Outdated Show resolved Hide resolved
components/ui/Global/Global.html Outdated Show resolved Hide resolved
components/ui/Global/Global.vue Outdated Show resolved Hide resolved
components/ui/Global/Global.vue Outdated Show resolved Hide resolved
components/views/friends/search/Search.vue Outdated Show resolved Hide resolved
components/views/navigation/mobile/toolbar/Toolbar.vue Outdated Show resolved Hide resolved
components/views/navigation/mobile/toolbar/Toolbar.vue Outdated Show resolved Hide resolved
components/views/navigation/toolbar/alerts/Alerts.vue Show resolved Hide resolved
libraries/Iridium/NotificationManager.ts Show resolved Hide resolved
libraries/Iridium/friends/FriendsManager.ts Show resolved Hide resolved
@aewing aewing marked this pull request as ready for review August 30, 2022 01:19
@aewing aewing removed the draft A developer wants eyes on this PR, but they don't think it's ready to merge. label Aug 30, 2022
@aewing aewing changed the title feat(refactor): pre-launch cleanup (wip, will be broken up) feat(refactor): pre-launch cleanup, offline sync, reactivity & observable bugfixes, emitter & pubsub bugfixes Aug 30, 2022
@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Aug 30, 2022
@aewing aewing merged commit 9b59735 into dev Aug 30, 2022
@aewing aewing deleted the refactor/pre-launch-cleanup branch August 30, 2022 04:44
@github-actions github-actions bot removed the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmcg josephmcg josephmcg requested changes

@WanderingHogan WanderingHogan WanderingHogan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aewing @WanderingHogan @josephmcg @stavares843