Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jest): 100% coverage for Iridium/chat/types #4292

Merged
merged 4 commits into from
Aug 18, 2022
Merged

feat(jest): 100% coverage for Iridium/chat/types #4292

merged 4 commits into from
Aug 18, 2022

Conversation

drepram
Copy link
Contributor

@drepram drepram commented Aug 16, 2022

What this PR does πŸ“–

Self-explanatory

Which issue(s) this PR fixes πŸ”¨

AP-2132

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 16, 2022
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 16, 2022
@stavares843 stavares843 reopened this Aug 16, 2022
@stavares843 stavares843 added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 16, 2022
stavares843
stavares843 requested changes Aug 16, 2022
View reviewed changes
@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Aug 16, 2022
@drepram drepram removed the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label Aug 18, 2022
@drepram
Copy link
Contributor Author

drepram commented Aug 18, 2022

After I committed my changes, 1 test failed libraries/BlockchainClient/adapters/Phantom/PhantomAdapter.test.ts.

I do not see the relation between the file in this PR with that test that's returning an error, but I find the use in bringing it up so that we may resolve it quickly.

@stavares843 stavares843 added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 18, 2022
@stavares843
Copy link
Member

Captura de ecrã 2022-08-18, às 12 03 41

its all green on CI

is also all green locally, not sure why you got that error

@stavares843 stavares843 added ready to merge Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA ready to merge labels Aug 18, 2022
@stavares843 stavares843 requested a review from aewing August 18, 2022 12:52
@WanderingHogan WanderingHogan merged commit 795f4ce into dev Aug 18, 2022
@WanderingHogan WanderingHogan deleted the AP-2132 branch August 18, 2022 19:28
@github-actions github-actions bot removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA feel free to merge hogan labels Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavares843 stavares843 stavares843 approved these changes

@WanderingHogan WanderingHogan Awaiting requested review from WanderingHogan

@aewing aewing Awaiting requested review from aewing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drepram @stavares843 @WanderingHogan