Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iridium): add member to group #4126

Merged
merged 4 commits into from
Aug 4, 2022
Merged

feat(iridium): add member to group #4126

merged 4 commits into from
Aug 4, 2022

Conversation

jasonwoodland
Copy link
Contributor

What this PR does 📖

  • Fix group invite relative position
  • Connect group invite UI to iridium

Which issue(s) this PR fixes 🔨
AP-2025

Special notes for reviewers 🗒️

  • Although the user is added to the group in both the group and conversation manager, the members list was not updated in the Toolbar component.

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 4, 2022
@jasonwoodland jasonwoodland changed the title Ap2025 feat(iridium): add member to group Aug 4, 2022
@Satellite-im Satellite-im deleted a comment from github-actions bot Aug 4, 2022
@jasonwoodland jasonwoodland marked this pull request as ready for review August 4, 2022 05:49
nathan-power
nathan-power suggested changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@nathan-power nathan-power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple things to look over

nathan-power
nathan-power approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@nathan-power nathan-power left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nathan-power nathan-power merged commit 12f5c6b into iridium-dev Aug 4, 2022
@nathan-power nathan-power deleted the AP2025 branch August 4, 2022 07:45
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-power nathan-power nathan-power approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonwoodland @nathan-power