Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat): create groups and render in sidebar #4033

Merged
merged 3 commits into from
Jul 22, 2022
Merged

feat(chat): create groups and render in sidebar #4033

merged 3 commits into from
Jul 22, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Jul 22, 2022 •
edited
Loading

What this PR does 📖

  • refactor userpicker to use iridium friends list
  • refactor and move GroupIcon component
    • change size to be the same as UiUserState (36px) instead of 40
    • simplify styles and html
  • flesh out quickchat popup
    • remove render condition from store since its only handled in sidebar component
    • use v-model.trim to avoid needing to trim in guard clause (learn something new everyday)
  • remove unused GroupClickable now that the sidebarItem component exists

Which issue(s) this PR fixes 🔨
AP-2002

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jul 22, 2022
@josephmcg josephmcg added iridium-dev draft A developer wants eyes on this PR, but they don't think it's ready to merge. labels Jul 22, 2022
@josephmcg josephmcg removed the draft A developer wants eyes on this PR, but they don't think it's ready to merge. label Jul 22, 2022
@josephmcg
Copy link
Contributor Author

oh man i wrote up some longwinded explanation of everything here in the PR description but forgot to save, 1 sec

@WanderingHogan WanderingHogan merged commit 864e5ea into iridium-dev Jul 22, 2022
@WanderingHogan WanderingHogan deleted the AP2002 branch July 22, 2022 16:58
@github-actions github-actions bot removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA iridium-dev labels Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molimauro molimauro molimauro left review comments

@WanderingHogan WanderingHogan WanderingHogan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephmcg @WanderingHogan @molimauro