Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mobile): long press context menu #4022

Merged
merged 8 commits into from
Jul 27, 2022
Merged

feat(mobile): long press context menu #4022

merged 8 commits into from
Jul 27, 2022

Conversation

jasonwoodland
Copy link
Contributor

@jasonwoodland jasonwoodland commented Jul 20, 2022 •
edited by nathan-power
Loading

What this PR does 📖

  • Adds compatibility to open context menus for mobile in the form of action sheets.

Which issue(s) this PR fixes 🔨
AP-1996

Special notes for reviewers 🗒️

Additional comments 🎤

@jasonwoodland jasonwoodland added the draft A developer wants eyes on this PR, but they don't think it's ready to merge. label Jul 20, 2022
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jul 20, 2022
@josephmcg josephmcg marked this pull request as draft July 20, 2022 04:02
@josephmcg josephmcg removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jul 20, 2022
@nathan-power nathan-power self-assigned this Jul 25, 2022
@josephmcg josephmcg marked this pull request as ready for review July 25, 2022 09:05
@josephmcg josephmcg added missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa and removed draft A developer wants eyes on this PR, but they don't think it's ready to merge. labels Jul 25, 2022
@josephmcg josephmcg added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa labels Jul 26, 2022
@josephmcg
Copy link
Contributor

gave bug feedback via DM, will revise and check later

@josephmcg josephmcg removed the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label Jul 27, 2022
@josephmcg josephmcg merged commit 9be2e8c into iridium-dev Jul 27, 2022
@josephmcg josephmcg deleted the AP1996 branch July 27, 2022 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmcg josephmcg josephmcg approved these changes

Assignees

@nathan-power nathan-power

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasonwoodland @josephmcg @stavares843 @nathan-power