-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(friends-requests): improved requests and notifications display #3955
Conversation
@josephmcg let me know what you think about these changes! 🔨 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple ideas regarding FriendsManager state structure. If we switched details and requests to arrays, it would simplify a lot of this logic and improve Vue reactivity
iridium.friends?.on('request/error', (err) => { | ||
this.error = err | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be simpler to wrap the error creating methods in a try/catch (or promise.catch if async)?
Quick recap:
Errors management is still in progress and has to be improved. 🔨 Any suggestion to improved this code are well welcomed!! 💥🚀 |
8e6bac3
to
05138e1
Compare
we can come back to smaller things like this on cleanup, this pr is a good one to build off of
What this PR does 📖
Fixed friends requests display
Which issue(s) this PR fixes 🔨
AP-1954
Special notes for reviewers 🗒️
Additional comments 🎤
Still missing some data to show (name and image, just when the other user hasn't accepted the request)