Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chatbar): prevent send if over limit, switch limit to be more accurate #3473

Merged
merged 1 commit into from
Jun 7, 2022
Merged

fix(chatbar): prevent send if over limit, switch limit to be more accurate #3473

merged 1 commit into from
Jun 7, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Jun 6, 2022 •
edited
Loading

What this PR does 📖

  • switch sendMessage to guard clause if missing recipient rather than 1 big nested if
  • add permanent transparent border to avoid content shift with an input length error
  • switch message length counter to honor the actual length of emojis
  • prevent message send if over length

Which issue(s) this PR fixes 🔨
AP-1722

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jun 6, 2022
@netlify
Copy link

netlify bot commented Jun 6, 2022

✅ Yeeeehaw, deploy preview is ready!

Name Link
🔨 Latest commit f48846f
🔍 Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/629d821ee8f8580008229e25
😎 Deploy Preview https://deploy-preview-3473--adoring-edison-dbcef8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jekrimo Jekrimo added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Jun 6, 2022
@stavares843 stavares843 added testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. 1 more code review needed and removed Ready for QA Ready for QA team to test, Devs approved. testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. labels Jun 6, 2022
@stavares843 stavares843 requested a review from molimauro June 6, 2022 16:39
@josephmcg josephmcg added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA and removed 1 more code review needed labels Jun 7, 2022
@molimauro molimauro added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Jun 7, 2022
@stavares843 stavares843 merged commit 6fb5607 into dev Jun 7, 2022
@stavares843 stavares843 deleted the AP1722 branch June 7, 2022 11:53
@github-actions github-actions bot removed the Ready for QA Ready for QA team to test, Devs approved. label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jekrimo Jekrimo Jekrimo approved these changes

@stavares843 stavares843 stavares843 approved these changes

@molimauro molimauro molimauro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephmcg @Jekrimo @stavares843 @molimauro