Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(volume): bind output slider volume to stream volume #3453

Merged
merged 4 commits into from
Jun 7, 2022
Merged

fix(volume): bind output slider volume to stream volume #3453

merged 4 commits into from
Jun 7, 2022

Conversation

maljuburi
Copy link
Contributor

@maljuburi maljuburi commented Jun 3, 2022 •
edited
Loading

What this PR does 📖

  • add a volume watcher to update the audioStream element
  • set initial volume when audioStream is set to the current volume state

Which issue(s) this PR fixes 🔨
AP-352

Additional comments 🎤

  • 🎊 This is my first PR, please review carefully and don't hesitate to give feedback and share knowledge 🙂

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jun 3, 2022
@netlify
Copy link

netlify bot commented Jun 3, 2022 •
edited
Loading

✅ Yeeeehaw, deploy preview is ready!

Name Link
🔨 Latest commit 79eac5b
🔍 Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/629f642af60aa200083200f6
😎 Deploy Preview https://deploy-preview-3453--adoring-edison-dbcef8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

molimauro
molimauro reviewed Jun 6, 2022
View reviewed changes
components/ui/Chat/TypingIndicator/TypingIndicator.vue Outdated
@@ -22,7 +22,7 @@ export default Vue.extend({
*/
methods: {
checkUsersTyping() {
if (this.users.length <= 3 && this.users.length != 0) {
if (this.users.length <= 3 && this.users.length !== 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be refactored to if (this.users.length <= 3 && this.users.length)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good callout

molimauro
molimauro suggested changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@molimauro molimauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Muhammad! Thanks for the first PR :) just a couple of minors and the rest looks good!

@molimauro molimauro added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Jun 6, 2022
@molimauro
Copy link
Contributor

Oh also in the section Which issue(s) this PR fixes 🔨 we normally put the AP-123 ticket in order to trigger various automation for Jira ;)

@molimauro molimauro added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Jun 7, 2022
@stavares843 stavares843 added testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. Ready for QA Ready for QA team to test, Devs approved. and removed Ready for QA Ready for QA team to test, Devs approved. testing blocked There is an issue outside of the app that prevents testing. EG Infrastructure issues. labels Jun 7, 2022
@stavares843 stavares843 added Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Jun 7, 2022
@stavares843
Copy link
Member

Hogan has a couple changes to request on these code changes.

@WanderingHogan
Copy link
Contributor

i dunno what i was thinking on that call earlier. When i skimmed it i thought this was doing something else. Good job, Muhammad!

@phillsatellite phillsatellite added QA tested One QA Person has tested - Needs QA Lead review still and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Jun 7, 2022
@stavares843 stavares843 merged commit 8bd4458 into dev Jun 7, 2022
@stavares843 stavares843 deleted the AP-352 branch June 7, 2022 23:04
@github-actions github-actions bot removed the QA tested One QA Person has tested - Needs QA Lead review still label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@molimauro molimauro molimauro approved these changes

@WanderingHogan WanderingHogan WanderingHogan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maljuburi @molimauro @stavares843 @WanderingHogan @phillsatellite