Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toolbar): new group modal position #3364

Merged
merged 1 commit into from
May 30, 2022
Merged

fix(toolbar): new group modal position #3364

merged 1 commit into from
May 30, 2022

Conversation

AlexZakablukov
Copy link
Contributor

What this PR does πŸ“–
new group modal position

Which issue(s) this PR fixes πŸ”¨
AP-1490

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label May 30, 2022
@netlify
Copy link

netlify bot commented May 30, 2022

βœ… Yeeeehaw, deploy preview is ready!

Name Link
πŸ”¨ Latest commit 6e1b246
πŸ” Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/6294cf209f84700008b16d2f
😎 Deploy Preview https://deploy-preview-3364--adoring-edison-dbcef8.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

stavares843
stavares843 approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captura de ecrã 2022-05-30, às 15 18 32

Captura de ecrã 2022-05-30, às 15 18 43

on a call it has a different position compared with outside the call but fine with addressing this on other PR πŸ’₯

@stavares843 stavares843 added the QA tested One QA Person has tested - Needs QA Lead review still label May 30, 2022
@stavares843 stavares843 requested a review from molimauro May 30, 2022 15:01
@molimauro molimauro removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label May 30, 2022
@stavares843 stavares843 merged commit 62e980f into dev May 30, 2022
@stavares843 stavares843 deleted the AP-1490 branch May 30, 2022 15:08
@github-actions github-actions bot removed the QA tested One QA Person has tested - Needs QA Lead review still label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molimauro molimauro molimauro approved these changes

@stavares843 stavares843 stavares843 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexZakablukov @stavares843 @molimauro