feat(jest): 58% coverage for TextileFileSystem.ts #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Dev Review
|
✔️ Yeeeehaw, deploy preview is ready! 🔨 Explore the source changes: 63b690f 🔍 Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/622b70eb4fe62100087dbe82 😎 Browse the preview: https://deploy-preview-2300--adoring-edison-dbcef8.netlify.app |
phillsatellite
approved these changes
Mar 11, 2022
phillsatellite
added
the
QA tested
stavares843
approved these changes
Mar 11, 2022
github-actions
bot
removed
Missing Dev Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
The image above is captured before this PR was made; the error
file.arrayBuffer is not a functionoccurred because of the change being made in the Fil constructor. This error was able to be resolved by passing in a dummy file, this was advised by Joe.Which issue(s) this PR fixes 🔨
AP-1062
Special notes for reviewers 🗒️
Soon we will be able to cover more (the HEIC code lines). For now I think this is sufficient, though do let me know if it is not.
Additional comments 🎤