fix(friends): remove conversation attached to friend (#4164)

libraries/Iridium/chat/ChatManager.ts

@@ -173,8 +173,7 @@ export default class ChatManager extends Emitter<ConversationMessage> {
   }
 
   /**
-   * @param {string} name new item name
-   * @param {IridiumDirectory} parent empty string if root element
+   * @param {string} friendDid
    * @description fetch direct conversation id based on friend did.
    * significantly faster than Iridium.hash until about 5,000,000 conversation records
    */
@@ -228,6 +227,15 @@ export default class ChatManager extends Emitter<ConversationMessage> {
     }
   }
 
+  async deleteConversation(id: Conversation['id']) {
+    if (!this.hasConversation(id)) {
+      return
+    }
+    Vue.delete(this.state.conversations, id)
+    this.set('/conversations', this.state.conversations)
+    // todo - do we need to unsubscribe too?
+  }
+
   getConversation(id: Conversation['id']): Conversation {
     const conversation = this.state.conversations[id]
     if (!conversation) {

libraries/Iridium/friends/FriendsManager.ts

@@ -468,15 +468,14 @@ export default class FriendsManager extends Emitter<IridiumFriendPubsub> {
       throw new Error(FriendsError.FRIEND_NOT_FOUND)
     }
 
-    Vue.delete(this.state.details, didUtils.didString(did))
+    const didString = didUtils.didString(did)
+
+    Vue.delete(this.state.details, didString)
     await this.set(`/details`, this.state.details)
-    const id = await encoding.hash(
-      [friend.did, this.iridium.connector?.id].sort(),
-    )
-    if (id && this.iridium.chat.hasConversation(id)) {
-      Vue.delete(this.iridium.chat.state.conversations, id)
+    const id = this.iridium.chat.directConversationIdFromDid(didString)
+    if (id) {
+      this.iridium.chat.deleteConversation(id)
     }
-
     logger.info(this.loggerTag, 'friend removed', { did, friend })
 
     // Announce to the remote user