Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline: Fix CAWP error with terms ending in early January #3926

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

benhammondmusic
Copy link
Collaborator

Description and Motivation

  • fixes issue where CAWP was only listing women in the full year they served, but our code for extracting denominators for US Congress was counting the last few days of people's terms, (january 1-3) and including that year in the denominator calculations. this resulted in the weird "bumpiness" of the chart, which is now fixed
  • adds usecols to speed up loading of giant csv file

Has this been tested? How?

  • tests passing

Screenshots (if appropriate)

OLD DATA LEFT / NEW MORE ACCURATE DATA RIGHT

Screenshot 2025-01-23 at 2 10 33 PM

Types of changes

(leave all that apply)

  • Bug fix

New frontend preview link is below in the Netlify comment 😎

@benhammondmusic benhammondmusic marked this pull request as ready for review January 23, 2025 22:56
@benhammondmusic benhammondmusic merged commit 00feb23 into SatcherInstitute:main Jan 23, 2025
8 checks passed
@benhammondmusic benhammondmusic deleted the fix-cawp-jan branch January 23, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants