Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Updates Biome script #3872

Merged
merged 33 commits into from
Dec 16, 2024

Conversation

benhammondmusic
Copy link
Collaborator

@benhammondmusic benhammondmusic commented Dec 13, 2024

Description and Motivation

  • moves the existing Biome work in progress action to be job in the frontend tests action
  • a Biome check (without applying any auto-fixes) will run and alert the dev if the submitted frontend/src code hasn't been properly formatted using our biome settings
  • it also gives some instructions on how to manually run an npm script command to apply fixes, and some suggestions on how to fix their pre-commit setup that must not be working if biome wasn't auto applied
  • adds that npm script option for manually fixing ALL frontend/src files
  • checks in some applied biome-fixes

Has this been tested? How?

  • passing, and failing as expected when I force push a linting error

Screenshots (if appropriate)

Screenshot 2024-12-13 at 9 22 32 PM Screenshot 2024-12-13 at 9 26 25 PM

Types of changes

(leave all that apply)

  • Refactor / chore

New frontend preview link is below in the Netlify comment 😎

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for health-equity-tracker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 486fdd0
🔍 Latest deploy log https://app.netlify.com/sites/health-equity-tracker/deploys/675d0916b2a3aa0008b85d60
😎 Deploy Preview https://deploy-preview-3872--health-equity-tracker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benhammondmusic benhammondmusic marked this pull request as ready for review December 14, 2024 04:34
Copy link
Collaborator

@eriwarr eriwarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@benhammondmusic benhammondmusic merged commit 7e6cb4f into SatcherInstitute:main Dec 16, 2024
11 checks passed
kccrtv pushed a commit to kccrtv/health-equity-tracker that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants