Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend: Demo in madlib #3870

Merged
merged 17 commits into from
Dec 19, 2024
Merged

Frontend: Demo in madlib #3870

merged 17 commits into from
Dec 19, 2024

Conversation

benhammondmusic
Copy link
Collaborator

@benhammondmusic benhammondmusic commented Dec 13, 2024 •
edited
Loading

Description and Motivation

  • specify "at birth" on sex demographic type, capitalize /Ethnicity
  • adds demographic selector component inside MadLib
  • new font size that's fluid based on window width, with clamped min/max size
  • defaults to race/eth if available, otherwise the first valid demo option for the given topics
  • better semantic html for some components, fix some biome caught a11y issues
  • simplify e2e tests; update with new demo location and values

Has this been tested? How?

  • tests updated and passing

Screenshots (if appropriate)

Dynamic text size:

Screen.Recording.2024-12-17.at.3.23.58.PM.mov-shrunk.mp4
Screenshot 2024-12-12 at 9 11 08 PM Screenshot 2024-12-12 at 9 11 39 PM Screenshot 2024-12-12 at 9 13 08 PM

Types of changes

(leave all that apply)

  • New content or feature

New frontend preview link is below in the Netlify comment 😎

@netlify Netlify
Copy link

netlify bot commented Dec 13, 2024

✅ Deploy Preview for health-equity-tracker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bec1eac
🔍 Latest deploy log https://app.netlify.com/sites/health-equity-tracker/deploys/675ba369b77cbd000873db79
😎 Deploy Preview https://deploy-preview-3870--health-equity-tracker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 13, 2024 •
edited
Loading

✅ Deploy Preview for health-equity-tracker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6bea16d
🔍 Latest deploy log https://app.netlify.com/sites/health-equity-tracker/deploys/676464e38b7c0c000829e16b
😎 Deploy Preview https://deploy-preview-3870--health-equity-tracker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benhammondmusic benhammondmusic marked this pull request as ready for review December 18, 2024 23:47
kccrtv
kccrtv approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@kccrtv kccrtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 dope! thanks ben!

@benhammondmusic benhammondmusic merged commit f1a46db into SatcherInstitute:main Dec 19, 2024
11 checks passed
@benhammondmusic benhammondmusic deleted the demo-madlib branch December 19, 2024 19:11
@kccrtv kccrtv mentioned this pull request Dec 19, 2024
Merged
kccrtv added a commit that referenced this pull request Dec 19, 2024
@kccrtv
adjusts spacing on demo, topic, and data type selectors (#3889)
9583853 
# Description and Motivation
piggybacks off of newly released #3870 with spacing adjustments on
`HetListBoxOption` list items

## Has this been tested? How?
tests passing

## Screenshots (if appropriate)

![selectors](https://github.com/user-attachments/assets/e2a1f5cc-c397-4384-8da8-fd7673d2ca2f)

## Types of changes
- Bug fix

## New frontend preview link is below in the Netlify comment 😎
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kccrtv kccrtv kccrtv approved these changes

@eriwarr eriwarr Awaiting requested review from eriwarr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benhammondmusic @kccrtv