Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R23 and R24 absorption model, minor fixes #25

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Add R23 and R24 absorption model, minor fixes #25

merged 5 commits into from
Jul 12, 2024

Conversation

slarosa
Copy link
Collaborator

@slarosa slarosa commented Jul 12, 2024

No description provided.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.53% (target: -1.00%) 96.52%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0d8be3a) 2695 2380 88.31%
Head commit (aee0be6) 2877 (+182) 2556 (+176) 88.84% (+0.53%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#25) 201 194 96.52%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 95.07042% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.11%. Comparing base (0d8be3a) to head (aee0be6).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   89.34%   90.11%   +0.77%     
==========================================
  Files          17       17              
  Lines        1820     1942     +122     
==========================================
+ Hits         1626     1750     +124     
+ Misses        194      192       -2     
Files Coverage Δ
pyrtlib/rt_equation.py 91.52% <ø> (+0.84%) ⬆️
pyrtlib/utils.py 94.07% <ø> (+1.43%) ⬆️
pyrtlib/absorption_model.py 91.55% <95.07%> (+1.39%) ⬆️

... and 1 file with indirect coverage changes

@slarosa slarosa merged commit 56ebc30 into main Jul 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants