computecloth: Optimize barriers and add compute queue double buffering #1128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the concerns raised in #1097:
VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT
instead ofVK_PIPELINE_STAGE_VERTEX_INPUT_BIT
, with access mask now set toVK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT
. The previous settings seemed to work, but I believe these are more correct.COMPUTE_CMD_BUFFERS
define is available to switch between double and single buffered operation. Default setting isCOMPUTE_CMD_BUFFERS = 2
for double buffering, but can be set= 1
for experimentation. See the following AMD GPU Profiler traces for insight.Changes tested on Windows 10, Manjaro Linux, macOS Ventura 13.6.6 with no validation errors or warnings.
Single buffering / Serial queue operation (
COMPUTE_CMD_BUFFERS = 1
):Double buffering / Parallel queue operation (
COMPUTE_CMD_BUFFERS = 2
):