Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [NoScaleOffset] to _UvAnimMaskTexture #72

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Add [NoScaleOffset] to _UvAnimMaskTexture #72

merged 1 commit into from
Jun 5, 2019

Conversation

iCyP
Copy link
Contributor

@iCyP iCyP commented Jun 4, 2019

Do you forget [NoScaleOffset] to _UvAnimMaskTexture?

@iCyP
Add [NoScaleOffset] to _UvAnimMaskTexture
65c699c 
Do you forget [NoScaleOffset] to _UvAnimMaskTexture?
@iCyP
Copy link
Contributor Author

iCyP commented Jun 4, 2019

my mistake

@iCyP iCyP closed this Jun 4, 2019
@Santarh
Copy link
Owner

Santarh commented Jun 4, 2019

Thanks for your Pull Request.
Yes, _UvAnimMaskTexture doesn't need its own scaleOffset.
Fortunately, all textures use _MainTex_ST in shader implementation and scaleOffset property doesn't appear in inspector.
But... for consistency, I think this pull request is needed.

@Santarh Santarh reopened this Jun 5, 2019
@Santarh Santarh merged commit eaa7d80 into Santarh:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iCyP @Santarh