Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Facial Recognition with EfficientNet B1 Model #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

infiniteoverflow
Copy link

Issue Number

ISSUE #37

Describe the changes you've made

I have added a Face Recognition model trained using EfficientNet B1 Architecture.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • The title of my pull request is a short description of the requested changes.

@welcome
Copy link

welcome bot commented Jan 30, 2021

Hello there!👋 Welcome to the project!💖

Thank you and congrats🎉 for opening your first pull request. Please adhere to our Code of Conduct.🙌 We will get back to you as soon as we can 😄.

Copy link
Owner

@SanjayMarreddi SanjayMarreddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@infiniteoverflow It looks fine. Could you please look into the below points and modify accordingly :

  • You have made Facial Emotion Recognition Model right , so create a new folder Facial_Emotion_Recognition_Models in the root folder and add your Recognition using Efficient Net B1
  • Remove the currently commented(not required) parts in the Jupyter Notebook.
  • Add the Inline Comments or Mark Down Text in the Notebook to help users understand the code better.
  • Also you can put the Link of Trained Model (Weights and .h5) in the README along with the Input and Output parameters so that users need not train model again. Also, can you explain a bit about Model you have trained in the README
  • Finally, You can test the Model on a Real Image (May be Your Image/ Some Random Image from Net) and show its prediction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants