Added "Deprecated" Attribute to Necessary Reduction and Barrier Routines #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced deprecated reduction and barrier routines in the unit tests. In situations where the active set syntax was actually used, the reductions were wrapped in an ifdef.
Removed unused variables and wrapped deprecated barrier API in ifdef's
davidozog
reviewed
Oct 19, 2021
|
Also, should we update the |
… pr/deprecated_sync_reductions
10 tasks
|
@wrrobin and @kholland-intel - I created issue #1025 in case we want to tackle that piecemeal in a separate PR(s). |
wrrobin
reviewed
Oct 22, 2021
wrrobin
reviewed
Oct 22, 2021
Also, updated shmem_sync to shmem_team_sync in repeated bariers test
wrrobin
approved these changes
Oct 25, 2021
|
LGTM. Created a separate PR #1026 for other examples tests to comply. So, this should be good to merge. |
davidozog
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Deprecated attribute to the active-set based reduction and barrier APIs. Also updated unit tests to either remove deprecated API calls or to wrap them in an ifdef:
ENABLE_DEPRECATED_TESTS.This PR addresses issue #898