upgrade preset ES6/7 from create-react-app #9
Conversation
| @@ -5,9 +5,9 @@ | |||
| "main": "./lib/index.js", | |||
| "scripts": { | |||
| "lint": "eslint .", | |||
| "prepublish": "babel --out-dir ./lib ./src", | |||
| "prepublish": "NODE_ENV=development babel --out-dir ./lib ./src", | |||
There was a problem hiding this comment.
why ? the prepublish should compile it for NPM (production like)
There was a problem hiding this comment.
I had an issue with babel, not sure if it's just my machine, but it was complaining that I needed to pass an environment. I can look more into this.
There was a problem hiding this comment.
can you try removing it and trying it out on your machine? It looks like it is required for the preset update, it's pretty harmless, and I've tested it and verified the output code works.
There was a problem hiding this comment.
specifically:
Error: Using `babel-preset-react-app` requires that you specify `NODE_ENV` or `BABEL_ENV` environment variables.
There was a problem hiding this comment.
FYI, using NODE_ENV=production is probably what you want here
| @@ -1,6 +1,5 @@ | |||
| { | |||
| "presets": [ | |||
| "es2015", | |||
There was a problem hiding this comment.
I wanted to upgrade things to the support the preset used by facebook incubator, it has 27k+ stars, so I think it's becoming very popular.
You can read more on it here:
https://github.com/facebookincubator/create-react-app/tree/master/packages/babel-preset-react-app
Now looking at it, I think it should read this instead of the words preset,
{
"presets": [
"react-app"
]
}
I'll look into this and update.
There was a problem hiding this comment.
oh, forgot to mention the main reason to move to this - this upgrade is required to use the javascript syntax used to cleanup and move away from .createClass and towards static props and es6 classes.
There was a problem hiding this comment.
es2015 is a subset of the react-app preset
There was a problem hiding this comment.
This is no longer the case, you might want to have react-app + use the babel-preset-env
@SamyPesse I updated to the latest preset, and also cleaned up some lint errors. There was nothing under
npm test, so all I've done is verify that it works with rendering components on a page.