Merge pull request jrit#17 from Josiah/correct-http-error-status

Return the correct status code on http error
SamuelTilly · Nov 3, 2015 · 8682781 · 8682781
2 parents 5f0ace4 + 410285d
commit 8682781
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/util.js b/src/util.js
@@ -94,7 +94,7 @@ util.getRemote = function( uri, callback, toDataUri )
             }
             else if( response.statusCode !== 200 )
             {
-                return callback( new Error( uri + " returned http " + response.code ) );
+                return callback( new Error( uri + " returned http " + response.statusCode ) );
             }
 
             if( toDataUri )

diff --git a/test/spec.js b/test/spec.js
@@ -284,7 +284,7 @@ describe( "html", function()
             },
             function( err, result )
             {
-                assert.equal( !!err, true );
+                assert.equal( err.message, "https://raw.githubusercontent.com/not-a-file.css returned http 400" );
                 done();
             }
         );
-Original file line number
+Diff line change
@@ Expand Up / @@ -284,7 +284,7 @@ describe( "html", function() @@
                 },
                 function( err, result )
                 {
-                    assert.equal( !!err, true );
+                    assert.equal( err.message, "https://raw.githubusercontent.com/not-a-file.css returned http 400" );
                     done();
                 }
             );
@@ Expand Down @@