Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to support multiple ble dongle and to use 21-digits paring code #146

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

dooho-lee
Copy link
Collaborator

@dooho-lee dooho-lee commented Jul 12, 2023

  1. fix to support multiple ble dongle
  2. fix to use 21-digits pairing code instead of 11-digits pairing code.

@dooho-lee dooho-lee linked an issue Jul 12, 2023 that may be closed by this pull request
@dooho-lee dooho-lee linked an issue Jul 12, 2023 that may be closed by this pull request
@dooho-lee dooho-lee changed the title 1. fix to support multiple ble dongle. 1. fix to support multiple ble dongle and to use 21-digits paring code Jul 12, 2023
@dooho-lee dooho-lee changed the title 1. fix to support multiple ble dongle and to use 21-digits paring code fix to support multiple ble dongle and to use 21-digits paring code Jul 12, 2023
@dooho-lee dooho-lee added bug Something isn't working enhancement New feature or request labels Jul 12, 2023
2. fix to use 21-digits pairing code instead of 11-digits pairing code.
- in case of 11-digits code, duplication can occur and another device can be onboarded.
- ioter-stable commit (aeaa2b6431b1893dbc02b81536a725010862d15d)

Signed-off-by: dooho88.lee <[email protected]>
@dooho-lee dooho-lee force-pushed the feature/multi_ble_and_change_pairingcode branch from f22dfb4 to fc39142 Compare July 12, 2023 09:47
Copy link
Collaborator

@junyong-sim junyong-sim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@spdkimo spdkimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dooho-lee dooho-lee merged commit 45cf940 into main Jul 12, 2023
@dooho-lee dooho-lee deleted the feature/multi_ble_and_change_pairingcode branch July 12, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some device's pairing code are duplicated Only one device can be onboarded at a time
3 participants