-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Divide file save function into 2 parts, add UTs #641
Conversation
Signed-off-by: Oleg Kopysov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
============================================
+ Coverage 93.63% 93.89% +0.25%
- Complexity 635 640 +5
============================================
Files 52 52
Lines 2185 2195 +10
Branches 255 254 -1
============================================
+ Hits 2046 2061 +15
+ Misses 62 58 -4
+ Partials 77 76 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no objections, approved.
Pull Request
Description
The file-saving function is divided into 2 parts for better maintenance.
Added unit tests to cover more branches.
Type of change
Please delete options that are not relevant.
Testing
Local run of UTs.
Checklist: