Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Divide file save function into 2 parts, add UTs #641

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

The file-saving function is divided into 2 parts for better maintenance.
Added unit tests to cover more branches.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Local run of UTs.

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the enhancement New feature or request label Oct 22, 2024
@o-kopysov o-kopysov added this to the v2.0.2 milestone Oct 22, 2024
@o-kopysov o-kopysov self-assigned this Oct 22, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.75510% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.89%. Comparing base (26d4ae7) to head (70f7be9).

Files with missing lines Patch % Lines
src/main/java/com/lpvs/util/LPVSFileUtil.java 86.66% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #641      +/-   ##
============================================
+ Coverage     93.63%   93.89%   +0.25%     
- Complexity      635      640       +5     
============================================
  Files            52       52              
  Lines          2185     2195      +10     
  Branches        255      254       -1     
============================================
+ Hits           2046     2061      +15     
+ Misses           62       58       -4     
+ Partials         77       76       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections, approved.

@o-kopysov o-kopysov merged commit 68e0ef8 into main Oct 22, 2024
10 checks passed
@o-kopysov o-kopysov deleted the refactor-utils branch October 22, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants