Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect conversion to string when equals to null #619

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Current PR contains a bug fix for the incorrect conversion to string when the queue element equals null.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Checked by functional tests.

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@o-kopysov o-kopysov added the fix label Sep 23, 2024
@o-kopysov o-kopysov added this to the v2.0.1 milestone Sep 23, 2024
@o-kopysov o-kopysov self-assigned this Sep 23, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.88%. Comparing base (9f5d6ba) to head (3016cfe).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #619      +/-   ##
============================================
+ Coverage     93.46%   93.88%   +0.42%     
  Complexity      623      623              
============================================
  Files            52       52              
  Lines          2127     2127              
  Branches        247      247              
============================================
+ Hits           1988     1997       +9     
+ Misses           65       56       -9     
  Partials         74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@o-kopysov o-kopysov marked this pull request as ready for review September 23, 2024 11:02
Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@o-kopysov o-kopysov merged commit 460f04c into main Sep 23, 2024
10 checks passed
@o-kopysov o-kopysov deleted the fix-to-string branch September 23, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants