Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix for incorrect increment of the attempts number #442

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

o-kopysov
Copy link
Collaborator

Pull Request

Description

Fix for the incorrect increment of attempts number in case of some fail during webhook processing.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Test Configuration:

  • Java: v17
  • LPVS Release: v1.4.1

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.76%. Comparing base (6fa0e02) to head (c8f0482).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #442   +/-   ##
=========================================
  Coverage     90.76%   90.76%           
  Complexity      489      489           
=========================================
  Files            47       47           
  Lines          1732     1732           
  Branches        207      207           
=========================================
  Hits           1572     1572           
  Misses           97       97           
  Partials         63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems logically. Approved.

@o-kopysov o-kopysov merged commit baedd56 into main Feb 23, 2024
10 checks passed
@o-kopysov o-kopysov deleted the fix-increment branch February 23, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants