fix: Clear the queue before adding new elements #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
=========================================
Coverage 90.75% 90.76%
Complexity 489 489
=========================================
Files 47 47
Lines 1731 1732 +1
Branches 207 207
=========================================
+ Hits 1571 1572 +1
Misses 97 97
Partials 63 63 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Oleg Kopysov <[email protected]>
tdrozdovsky
approved these changes
Feb 21, 2024
m-rudyk
reviewed
Feb 21, 2024
| @@ -147,6 +147,7 @@ public BlockingDeque<LPVSQueue> getQueue() { | |||
| * @throws InterruptedException If interrupted while processing the queue. | |||
| */ | |||
| public void checkForQueue() throws InterruptedException { | |||
| QUEUE.clear(); | |||
There was a problem hiding this comment.
As an option, I'd pur warning here if queue is not clear. Cause we should pay attention, some webhooks are not processed.
There was a problem hiding this comment.
I don't think that warning is needed here. This is the normal operation of the LPVS queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
The queue needs to be cleared before adding new elements.
Type of change
Please delete options that are not relevant.
Testing
Test Configuration:
Checklist: