Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update JDK11 to JDK17 in .github/workflows/publish-release.yml #423

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: Update JDK11 to JDK17 in .github/workflows/publish-release.yml #423

merged 1 commit into from
Feb 5, 2024

Conversation

tdrozdovsky
Copy link
Collaborator

Pull Request

Description

To successfully publish artifacts need to update JDK11 to JDK17

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • CI system update

Test Configuration:

  • Java: v17
  • LPVS Release: v1.4.1

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@tdrozdovsky tdrozdovsky added the fix label Feb 5, 2024
@tdrozdovsky tdrozdovsky added this to the v1.4.1 milestone Feb 5, 2024
@tdrozdovsky tdrozdovsky self-assigned this Feb 5, 2024
o-kopysov
o-kopysov approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

t-naumenko
t-naumenko approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@t-naumenko t-naumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

m-rudyk
m-rudyk approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@o-kopysov o-kopysov merged commit 54d70d5 into Samsung:main Feb 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-naumenko t-naumenko t-naumenko approved these changes

@m-rudyk m-rudyk m-rudyk approved these changes

@o-kopysov o-kopysov o-kopysov approved these changes

@o-konoval o-konoval Awaiting requested review from o-konoval

@tiokim tiokim Awaiting requested review from tiokim tiokim is a code owner

@MoonkiHong MoonkiHong Awaiting requested review from MoonkiHong MoonkiHong is a code owner

Assignees

@tdrozdovsky tdrozdovsky

Labels
fix
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@tdrozdovsky @o-kopysov @m-rudyk @t-naumenko