apply review

Samsung · Sep 12, 2023 · fc75c2e · fc75c2e
1 parent 99d8ea6
commit fc75c2e
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/src/main/java/com/lpvs/auth/OAuthService.java b/src/main/java/com/lpvs/auth/OAuthService.java
@@ -27,7 +27,7 @@
 @RequiredArgsConstructor
 public class OAuthService implements OAuth2UserService<OAuth2UserRequest, OAuth2User> {
 
-    private final LPVSMemberRepository LPVSMemberRepository;
+    private final LPVSMemberRepository lpvsMemberRepository;
 
     @Override
     public OAuth2User loadUser(OAuth2UserRequest userRequest) throws OAuth2AuthenticationException {
@@ -56,7 +56,7 @@ public OAuth2User loadUser(OAuth2UserRequest userRequest) throws OAuth2Authentic
 
     }
 
-    private Map customAttribute(Map attributes, String userNameAttributeName, MemberProfile memberProfile, String registrationId) {
+    private Map<String, Object> customAttribute(Map<String, Object> attributes, String userNameAttributeName, MemberProfile memberProfile, String registrationId) {
         Map<String, Object> customAttribute = new LinkedHashMap<>();
         customAttribute.put(userNameAttributeName, attributes.get(userNameAttributeName));
         customAttribute.put("provider", registrationId);
@@ -68,11 +68,11 @@ private Map customAttribute(Map attributes, String userNameAttributeName, Member
 
     private LPVSMember saveOrUpdate(MemberProfile memberProfile) {
 
-        LPVSMember LPVSMember = LPVSMemberRepository.findByEmailAndProvider(memberProfile.getEmail(), memberProfile.getProvider())
+        LPVSMember lpvsMember = lpvsMemberRepository.findByEmailAndProvider(memberProfile.getEmail(), memberProfile.getProvider())
                 .map(m -> m.update(memberProfile.getName(), memberProfile.getEmail()))
                 .orElse(memberProfile.toMember());
 
-        return LPVSMemberRepository.save(LPVSMember);
+        return lpvsMemberRepository.save(lpvsMember);
     }
 
 }
diff --git a/src/main/java/com/lpvs/controller/LPVSWebController.java b/src/main/java/com/lpvs/controller/LPVSWebController.java
@@ -14,7 +14,6 @@
 import org.springframework.web.bind.annotation.ResponseBody;
 
 @Controller
-@Slf4j
 public class LPVSWebController {
     private LPVSMemberRepository memberRepository;
     private LPVSDetectedLicenseRepository detectedLicenseRepository;

diff --git a/src/main/java/com/lpvs/exception/PageControllerAdvice.java b/src/main/java/com/lpvs/exception/PageControllerAdvice.java
@@ -21,7 +21,7 @@ public class PageControllerAdvice {
 
     @ExceptionHandler(LoginFailedException.class)
     public ResponseEntity<ErrorResponse> loginFailedHandle(LoginFailedException e) {
-        log.info("loginFailed");
+        log.error("loginFailed" + e.getMessage());
         errorResponse = new ErrorResponse(e.getMessage(), HttpStatus.UNAUTHORIZED.name(), HttpStatus.UNAUTHORIZED.value());
         return new ResponseEntity<>(errorResponse, HttpStatus.UNAUTHORIZED);
     }

diff --git a/src/main/java/com/lpvs/service/LPVSLoginCheckService.java b/src/main/java/com/lpvs/service/LPVSLoginCheckService.java
@@ -35,7 +35,6 @@ public Boolean oauthLoginStatus(Authentication authentication) {
             if (oAuth2User == null) {
                 return Boolean.FALSE;
             }
-            Map<String, Object> attributes = oAuth2User.getAttributes();
             return Boolean.TRUE;
         } catch (NullPointerException e) {
             return Boolean.FALSE;