Awesome but chrome is full of backdoors.... #2

LifeIsStrange · 2015-07-12T21:30:16Z

Yes there are chromium but the people use chrome instead of chromium or Iron...
So there is a port planned for implement gstreamer on Firefox ? :)
Sorry for bad english.

BUG=506498 Review URL: https://codereview.chromium.org/1225563004 Cr-Commit-Position: refs/heads/master@{#337381}

This ensures we won't use build-side python modules, and that any changes in src-side modules do take effect. This is a re-landing of https://codereview.chromium.org/1224593002 with a change to src/tools/telemetry/telemetry/TELEMETRY_DEPS . BUG=506498 Review URL: https://codereview.chromium.org/1218953003 Cr-Commit-Position: refs/heads/master@{#337387}

This reverts * "Remove Android-specific code from runtest.py" acdd38a3c64dd0aeaf82c4c63b6c669a573780d6. * "Clean up src-side runtest.py, patch #2 (remove log scraping)" d02a4df34615015cede40b8aed73b3320eddcc9b. Reason for reverting: All perf tests have started failing. See bug for details. [email protected], [email protected] [email protected], [email protected], [email protected], [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506498,507315 Review URL: https://codereview.chromium.org/1220423002 Cr-Commit-Position: refs/heads/master@{#337494}

…hset #2 id:20001 of https://codereview.chromium.org/1214903013/) Reason for revert: fails 'compile on ChromiumOS x86-generic Compile, Link: https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-generic%20Compile/builds/1797 Error like [6346/6381] RULE interactive_ui_tests_run: isolate_66259a49d84685497c67f134062c657d interactive_ui_tests.isolate /* snip */ FAILED: cd ../../chrome; python ../tools/isolate_driver.py check --isolated "../out_x86-generic/Release/interactive_ui_tests.isolated" --isolate "interactive_ui_tests.isolate" /* snip */ Failed to find an input file: Input file /b/build/slave/ChromiumOS_x86-generic_Compile/build/src/out_x86-generic/Release/nacl_irt_x86_64.nexe doesn't exist Original issue's description: > Remove chromeos==0 blacklist for test_isolation_mode. > > All of plain linux, chromeos work just fine and have been for a long time. > > iOS and Android are also using .isolate files but in a different enough way that > it's not using test_isolation_mode==check, at least not yet. > > [email protected] > BUG=98637 > > Committed: https://crrev.com/cf15207e009794f74915d9b10d2e838b0d0c86f2 > Cr-Commit-Position: refs/heads/master@{#337503} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Review URL: https://codereview.chromium.org/1227583002 Cr-Commit-Position: refs/heads/master@{#337533}

…set #8 id:140001 of https://codereview.chromium.org/1192663005/) Reason for revert: Flakily fails interactive_ui_tests on Linux Tests (dbg)(1)(32). Link: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/16214 failures: AppWindowHiddenKeepAliveTest.ShownThenHiddenThenShown Error: [1:8:0706/185834:FATAL:compositor_timing_history.cc(104)] Check failed: base::TimeTicks() != begin_main_frame_sent_time_ (0 bogo-microseconds vs. 0 bogo-microseconds) #0 0x0000ebbb49f4 base::debug::StackTrace::StackTrace() #1 0x0000ebc17bee logging::LogMessage::~LogMessage() #2 0x0000eec044b4 cc::CompositorTimingHistory::DidCommit() #3 0x0000eec043ab cc::CompositorTimingHistory::BeginMainFrameAborted() #4 0x0000eec0cfa5 cc::Scheduler::BeginMainFrameAborted() #5 0x0000eed51290 cc::ThreadProxy::BeginMainFrameAbortedOnImplThread() #6 0x0000eed60235 base::internal::RunnableAdapter\u003C>::Run() See also: https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)(32)/builds/16214 Original issue's description: > cc: Measure compositor timing with finer granularity > > Measures PrepareTiles, NotifyReadyToActivate, and > Activation times separately such that idle times > between actions don't polute results when the > main thread is in a high latency mode or when > actions are swap throttled. > > Also cleans up how we measure commit times and > adds DCHECKs to make sure we don't ruin the ordering > expectations of the CompositorTimingHistory class. > > Recording is only enabled while visible and we have > an output surface in order to avoid cleanup logic > skewing results. > > BUG=406158, 500744 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/65acb94f9258f985cbceedcd3b816cc55cc9522f > Cr-Commit-Position: refs/heads/master@{#337539} [email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=406158, 500744 Review URL: https://codereview.chromium.org/1213653005 Cr-Commit-Position: refs/heads/master@{#337553}

…em. (patchset #16 id:300001 of https://codereview.chromium.org/1179413010/) Reason for revert: I'm seeing the following crash when closing the Mandoline window on Linux: [0707/104753:FATAL:sqlite_persistent_cookie_store.cc(1135)] Check failed: false. Could not add a cookie to the DB. #0 0x00000046aef1 __interceptor_backtrace #1 0x7fec4b87954e base::debug::StackTrace::StackTrace() #2 0x7fec4b479a1d logging::LogMessage::~LogMessage() #3 0x7fec53f03c23 net::SQLitePersistentCookieStore::Backend::Commit() #4 0x7fec53f04f38 net::SQLitePersistentCookieStore::Backend::InternalBackgroundClose() #5 0x7fec53f1902b base::internal::RunnableAdapter<>::Run() Reverting this patch resolves the issue. Original issue's description: > mandoline filesystem: Save cookie data to the mojo:filesystem. > > This makes the network service use the sql vfs to proxy writing the > cookies to the filesystem service. This means mojo:network_service does > not directly write its data to the OS filesystem, which will allow us to > sandbox it. > > BUG=493311 > > Committed: https://crrev.com/bbb9e2f6486cccadde4dc2fa077af8f694105eaa > Cr-Commit-Position: refs/heads/master@{#337491} [email protected],[email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=493311 Review URL: https://codereview.chromium.org/1225673006 Cr-Commit-Position: refs/heads/master@{#337602}

- Remove Android-specific code from runtest.py (https://codereview.chromium.org/1222113004) - Clean up src-side runtest.py, patch #2 (remove log scraping) (https://codereview.chromium.org/1225563004) They were reverted in https://codereview.chromium.org/1220423002 for breaking chromium.perf . I've then landed the following changes to address that: - add --use-src-side-runtest-py flag to testing/scripts/common.py (https://codereview.chromium.org/1222903003) - make recipes pass --use-src-side-runtest-py to src-side scripts (https://codereview.chromium.org/1222793007) - make --use-src-side-runtest-py take effect for src-side testing scripts (https://codereview.chromium.org/1220923003) BUG=506498 Review URL: https://codereview.chromium.org/1226923002 Cr-Commit-Position: refs/heads/master@{#337611}

…. (patchset #3 id:220001 of https://codereview.chromium.org/1166523003/) Reason for revert: This change introduced a use-after free that lit up the memory waterfall. Links to a couple of affected bots: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/7754/steps/net_unittests/logs/stdio http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/2715/steps/net_unittests/logs/stdio http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%281%29/builds/42456/steps/memory%20test%3A%20net/logs/stdio http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%281%29/builds/1635/steps/memory%20test%3A%20net/logs/stdio Report: MojoProxyResolverV8TracingBindingsTest.Basic (run #1): [ RUN ] MojoProxyResolverV8TracingBindingsTest.Basic ==31178==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7fbd2d6e8eaf in NotifyEvent net/test/event_waiter.h:27:34 #1 0x7fbd2d6e8eaf in net::MojoProxyResolverV8TracingBindingsTest::Alert(mojo::String const&) net/proxy/mojo_proxy_resolver_v8_tracing_bindings_unittest.cc:33:0 #2 0x7fbd2d6e6ecb in AlertOnTaskRunner net/proxy/mojo_proxy_resolver_v8_tracing_bindings.h:67:7 #3 0x7fbd2d6e6ecb in net::MojoProxyResolverV8TracingBindings\u003Cnet::MojoProxyResolverV8TracingBindingsTest>::Alert(std::__1::basic_string\u003Cunsigned short, base::string16_char_traits, std::__1::allocator\u003Cunsigned short> > const&) net/proxy/mojo_proxy_resolver_v8_tracing_bindings.h:42:0 #4 0x7fbd2d6e0c7e in SendAlertAndError net/proxy/mojo_proxy_resolver_v8_tracing_bindings_unittest.cc:45:5 #5 0x7fbd2d6e0c7e in net::MojoProxyResolverV8TracingBindingsTest_Basic_Test::TestBody() net/proxy/mojo_proxy_resolver_v8_tracing_bindings_unittest.cc:62:0 #6 0x7fbd308384d7 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2420:12 #7 0x7fbd308384d7 in testing::Test::Run() testing/gtest/src/gtest.cc:2436:0 #8 0x7fbd3083b965 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5 #9 0x7fbd3083d322 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5 #10 0x7fbd3085b73a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4604:11 #11 0x7fbd3085a717 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12 #12 0x7fbd3085a717 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4222:0 #13 0x7fbd323e8959 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10 #14 0x7fbd323e8959 in base::TestSuite::Run() base/test/test_suite.cc:229:0 #15 0x7fbd323cded9 in Run base/callback.h:396:12 #16 0x7fbd323cded9 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:184:0 #17 0x7fbd323cd7a0 in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:423:10 #18 0x7fbd2fab8304 in main net/test/run_all_unittests.cc:64:10 #19 0x7fbd2745776c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226:0 #20 0x7fbd2b7d61a8 in _start ??:0:0 Uninitialized value was created by a heap allocation #0 0x7fbd2b82d402 in operator new(unsigned long) ??:0:0 #1 0x7fbd2d6e64e5 in testing::internal::TestFactoryImpl\u003Cnet::MojoProxyResolverV8TracingBindingsTest_Basic_Test>::CreateTest() testing/gtest/include/gtest/internal/gtest-internal.h:486:39 #2 0x7fbd3083b8ef in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::TestFactoryBase, testing::Test *> testing/gtest/src/gtest.cc:2420:12 #3 0x7fbd3083b8ef in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2603:0 #4 0x7fbd3083d322 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5 #5 0x7fbd3085b73a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4604:11 #6 0x7fbd3085a717 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12 #7 0x7fbd3085a717 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4222:0 #8 0x7fbd323e8959 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10 #9 0x7fbd323e8959 in base::TestSuite::Run() base/test/test_suite.cc:229:0 #10 0x7fbd323cded9 in Run base/callback.h:396:12 #11 0x7fbd323cded9 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:184:0 #12 0x7fbd323cd7a0 in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:423:10 #13 0x7fbd2fab8304 in main net/test/run_all_unittests.cc:64:10 #14 0x7fbd2745776c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226:0 SUMMARY: MemorySanitizer: use-of-uninitialized-value (/tmp/run_tha_testEIzO42/out/Release/net_unittests+0x2416eaf) Exiting Original issue's description: > Change the mojo ProxyResolver to use ProxyResolverV8Tracing. > > This allows a much simpler implementation of GetLoadState and forwarding > errors to a ProxyResolverErrorObserver as well as enabling a > straightforward implementation of NetLog event reporting. > > BUG=467832 > > Committed: https://crrev.com/9f5bf59b57e6b0662d9b9e0f6715ef7b5af092c0 > Cr-Commit-Position: refs/heads/master@{#337993} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467832 Review URL: https://codereview.chromium.org/1224083003 . Cr-Commit-Position: refs/heads/master@{#338019}

…work. (patchset #2 id:20001 of https://codereview.chromium.org/1223713004/) Reason for revert: See crbug.com/508509. We need to fix this case before relanding. Original issue's description: > Cleanup viewport scrolling for future scroll customization work. > > Viewport scrolling previously returned a struct of information about > what scrolled. This complicated scroll customization. This patch makes > |Viewport::ScrollBy| return a single |Vector2dF|, as well as performing > some other cleanup that will simplify scroll customization. > > BUG=505851 > TEST=LayerTreeHostImplTest, WebContentsViewAuraTest.VerticalOverscroll > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/3e773d7aeba1eb0077a7907d0f5ff2e72e1c6753 > Cr-Commit-Position: refs/heads/master@{#337694} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=505851 Review URL: https://codereview.chromium.org/1227823005 Cr-Commit-Position: refs/heads/master@{#338071}

…rg/1109333002 (patchset #2 id:20001 of https://codereview.chromium.org/1209233003/) Reason for revert: Merged to M44, now reverting... Original issue's description: > Temp & partially revert of cl https://codereview.chromium.org/1109333002, which caused regression crbug.com/493292. > > After the fix is verified on M44, this cl will be reverted for M45. > > [email protected] > BUG=493292 > TEST=None. > > Committed: https://crrev.com/57811a5a4556661b6513fd233b6294f9ce182ef4 > Cr-Commit-Position: refs/heads/master@{#336989} TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=493292 Review URL: https://codereview.chromium.org/1236783002 Cr-Commit-Position: refs/heads/master@{#338460}

…id:60001 of https://codereview.chromium.org/1179643007/) Reason for revert: Recover gfx:color-profile code (intent is to use this code). Original issue's description: > gfx: Remove dead-code related to color-profile. > > GetDisplayColorProfile() functions are never used from non-test code. So > remove the code and the corresponding tests. > > BUG=500004 > > Committed: https://crrev.com/8c9fc32f0286ac15309f54ab77f236aa51fb756e > Cr-Commit-Position: refs/heads/master@{#334309} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=500004 Review URL: https://codereview.chromium.org/1231603005 Cr-Commit-Position: refs/heads/master@{#338493}

… try) (patchset #2 id:20001 of https://codereview.chromium.org/1221333013/) Reason for revert: Speculative revert: appreas to have broken the GPU mac builders. http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%2010.9%20%28Intel%29%20%28dbg%29/builds/11045 .. 11141 Original issue's description: > Add support for escaped target names in isolate driver (4th try) > > Currently the isolate_driver.py which creates the dependency files > used by the isolate system, does a simple split on all spaces when > trying to identify targets. > > This can fail if the target name contains a space in the name. In > ninja, spaces are escaped with a $-prefix. An example would be > 'Content$ Shell$ Helper.app'. > > This CL adds support for such target names and ensures that they > stay as one item. Doing this uncovered a few missing dependencies > and a missing file in some .isolate-files for the component build > on Mac. > > 1st try: https://codereview.chromium.org/970203003/ > 1st revert: https://codereview.chromium.org/985753002/ > 2nd try: https://codereview.chromium.org/1103793002/ > 2nd revert: https://codereview.chromium.org/1129493003/ > 3rd try: https://codereview.chromium.org/1130523003/ > 3rd revert: https://codereview.chromium.org/1131363003/ > BUG=462248 > > Committed: https://crrev.com/c58992cc880b5bff5813276ee9d20a79be70b31f > Cr-Commit-Position: refs/heads/master@{#338402} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462248 Review URL: https://codereview.chromium.org/1227843004 Cr-Commit-Position: refs/heads/master@{#338497}

#9 id:160001 of https://codereview.chromium.org/1231453002/) Reason for revert: It looks like this is causing MSAN failures from an uninitialized variable in the webkit_tests: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/4378/steps/webkit_tests/logs/stdio 10:00:36.214 29049 ==29058==WARNING: MemorySanitizer: use-of-uninitialized-value 10:00:36.214 29049 #0 0x7f620bf62c3e in set_is_clipped cc/layers/layer.h:503:9 10:00:36.214 29049 #1 0x7f620bf62c3e in AddClipNodeIfNeeded<cc::Layer> cc/trees/property_tree_builder.cc:149:0 10:00:36.214 29049 #2 0x7f620bf62c3e in void cc::(anonymous namespace)::BuildPropertyTreesInternal<cc::Layer>(cc::Layer*, cc::(anonymous namespace)::DataForRecursion<cc::Layer> const&) cc/trees/property_tree_builder.cc:386:0 10:00:36.214 29049 #3 0x7f620bf5d128 in void cc::BuildPropertyTreesTopLevelInternal<cc::Layer>(cc::Layer*, cc::Layer const*, cc::Layer const*, cc::Layer const*, float, float, gfx::Rect const&, gfx::Transform const&, cc::PropertyTrees*) cc/trees/property_tree_builder.cc:466:3 10:00:36.214 29049 #4 0x7f620c206ee6 in cc::BuildPropertyTreesAndComputeVisibleRects(cc::Layer*, cc::Layer const*, cc::Layer const*, cc::Layer const*, float, float, gfx::Rect const&, gfx::Transform const&, cc::PropertyTrees*, std::__1::vector<scoped_refptr<cc::Layer>, std::__1::allocator<scoped_refptr<cc::Layer> > >*) cc/trees/draw_property_utils.cc:473:3 10:00:36.214 29049 #5 0x7f620be94a2f in cc::LayerTreeHost::DoUpdateLayers(cc::Layer*) cc/trees/layer_tree_host.cc:789:5 on pretty much every test. So I'm reverting this. Sorry! Original issue's description: > Compute if a layer is clipped outside CalcDrawProps > > We need to know if a layer is clipped to compute its drawable > visible rect. So, we need to compute it outside CalcDrawProps to move > drawable visible rect computation outside CalcDrawProps. > > Committed: https://crrev.com/2af7226e29be65a8ea4a279b9358a6fcfada5cd3 > Cr-Commit-Position: refs/heads/master@{#338515} [email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1236943002 Cr-Commit-Position: refs/heads/master@{#338542}

https://codereview.chromium.org/1225333002/) Reason for revert: Regressed perf on Nexus 7 BUG=509982,508005 Original issue's description: > Trace MessageLoop::RunTask execution > > Previously, we were only issuing trace events around the task execution > within TaskAnnotator::RunTask. However, this does not include time spent > in observers (see bug for details on how it bites). > > BUG=508005 > > Committed: https://crrev.com/87a2c639ff073ed3194a788ee1eaf82aabe77bab > Cr-Commit-Position: refs/heads/master@{#338492} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=508005 Review URL: https://codereview.chromium.org/1234573005 Cr-Commit-Position: refs/heads/master@{#338676}

…nt/test/gpu. (patchset #2 id:20001 of https://codereview.chromium.org/1231863008/) Reason for revert: This CL appears to be causing flakes on android_webview_webgl_conformance_tests, webgl_conformance_tests and gpu_rasterization_tests. See, for example, https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%209%29/builds/1079 https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%205%29/builds/975 Original issue's description: > Refactored TestExpectations out of Telemetry and into content/test/gpu. > > (Re-land of https://codereview.chromium.org/1224233005/ after fix for > blink_canvas.perf benchmark) > > The GPU tests are the primary user of Telemetry's TestExpectations, > and it turns out they can be implemented entirely in the code using > Telemetry, rather than Telemetry itself. For this reason, move them > into content/test/gpu. > > Refactored the GPU tests to all derive from a common set of base > classes implementing support for test expectations. Verified that > skipping tests, expected failures, and flaky test handling all work. > More tests of test expectations are needed, and will be added in later > CLs; this one is too large already, but can't be broken up further. > > Fixed up two WebGL perf tests that were relying on test expectations > to skip the pages on specific GPUs, and added a hook to Telemetry's > browser_info to enable this. > > This CL loses one valuable test, > testHandlingOfCrashedTabWithExpectedFailure, from > page_run_end_to_end_unittest.py. It will be reintroduced in a later CL. > > A subsequent CL will redesign TestExpectations. This CL is intended to > be a refactoring with no behavioral changes. > > Ran telemetry_unittests, telemetry_gpu_unittests, > telemetry_perf_unittests, and all GPU tests locally to verify. > > BUG=495870 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect > [email protected],[email protected],[email protected],[email protected] > > Committed: https://crrev.com/296319ccdb96f3f31df22f3b4ced4e040a864210 > Cr-Commit-Position: refs/heads/master@{#338768} [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=495870 Review URL: https://codereview.chromium.org/1233303002 Cr-Commit-Position: refs/heads/master@{#338811}

… M. (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/1235253005/) Reason for revert: Fix is no longer needed Original issue's description: > Add a workaround for Android Support Library bug on Android M. > > There is a bug in Android Support Library on Android M devices > when user brings up the ActionMode (cut, copy, paste) bar as it > breaks BACK button. This change forces Android Support library > not to handle action mode and let the system handle it instead. > > BUG=510128 > > Committed: https://crrev.com/e2b969edfca4d7f1961139249a9e41b45b9d2b50 > Cr-Commit-Position: refs/heads/master@{#338804} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510128 Review URL: https://codereview.chromium.org/1239803007 Cr-Commit-Position: refs/heads/master@{#338959}

…ttps://codereview.chromium.org/1223293004/) Reason for revert: This seems to not work: https://chromium-swarm.appspot.com/user/task/28ace3bc39b53310 Original issue's description: > Swarm setup_unittests on FYI bots. > > BUG=153829 > > Committed: https://crrev.com/b398dec5088da75d3fbfb8d810c9b6f69ec7182a > Cr-Commit-Position: refs/heads/master@{#338902} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=153829 Review URL: https://codereview.chromium.org/1239083002 Cr-Commit-Position: refs/heads/master@{#339026}

(Re-land #2 with fixes for handling crashed renderers and other bug fixes) (Original CL: https://codereview.chromium.org/1224233005/ ) (Re-land #1: https://codereview.chromium.org/1231863008/ ) The GPU tests are the primary user of Telemetry's TestExpectations, and it turns out they can be implemented entirely in the code using Telemetry, rather than Telemetry itself. For this reason, move them into content/test/gpu. Refactored the GPU tests to all derive from a common set of base classes implementing support for test expectations. Verified that skipping tests, expected failures, and flaky test handling all work. More tests of test expectations are needed, and will be added in later CLs; this one is too large already, but can't be broken up further. Fixed up two WebGL perf tests that were relying on test expectations to skip the pages on specific GPUs, and added a hook to Telemetry's browser_info to enable this. This CL loses one valuable test, testHandlingOfCrashedTabWithExpectedFailure, from page_run_end_to_end_unittest.py. It will be reintroduced in a later CL. A subsequent CL will redesign TestExpectations. This CL is intended to be a refactoring with no behavioral changes. Ran telemetry_unittests, telemetry_gpu_unittests, telemetry_perf_unittests, and all GPU tests locally to verify. BUG=495870 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect [email protected],[email protected],[email protected],[email protected] Review URL: https://codereview.chromium.org/1233133003 Cr-Commit-Position: refs/heads/master@{#339069}

…(patchset #2 id:20001 of https://codereview.chromium.org/1232963002/) Reason for revert: Broke a bot: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/10671 Original issue's description: > Sandbox: Make CreateRestrictedToken return a ScopedHandle. > > Removes raw handles from the API. > > BUG=426577 > > Committed: https://crrev.com/9808175ad322e8387366cdec088e65ccb934ceac > Cr-Commit-Position: refs/heads/master@{#339130} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=426577 Review URL: https://codereview.chromium.org/1240793004 Cr-Commit-Position: refs/heads/master@{#339140}

Summary of changes available at: https://chromium.googlesource.com/skia/+log/bea0150..ac66a81 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel [email protected] Commits in this roll: ac66a81 [email protected] Revert of Add fast normalize for SkLightingImageFilter. (patchset #2 id:20001 of https://codereview.chromium.org/1240023002/) ed7cf27 [email protected] Now that the SkImageFilter::CropRect crop edges refer to width & height, name them appropriately. 47d280d [email protected] Fix visual bench memory leak ef14cb3 [email protected] make glyph_pos imageblur* largeglyphblur portable 31b21f6 [email protected] Small fix for visualbench 1891863 [email protected] refactor code to apply the croprect dfa0ecf [email protected] Add fast normalize for SkLightingImageFilter. c1121ef [email protected] Stop running image tests on msaa. d2ce185 [email protected] make imagefilters* imagemagnifier imageresizetiled portable Review URL: https://codereview.chromium.org/1242523004 Cr-Commit-Position: refs/heads/master@{#339222}

…id:20001 of https://codereview.chromium.org/1232343006/) Reason for revert: This CL causes the Windows GN build to fail. Sample failure at http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/9607/steps/compile/logs/stdio Original issue's description: > components: Fix 'gn check' errors for omnibox. > > Tested on Linux with the following command lines: > > $ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1' > $ gn check out-gn/Release //components/omnibox/* > > BUG=367595, 376000 > TEST=see above > [email protected],[email protected],[email protected] > [email protected] > > Committed: https://crrev.com/fc240d37b0b23e1284ed943ea2a0830464190e20 > Cr-Commit-Position: refs/heads/master@{#339156} [email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=367595, 376000 Review URL: https://codereview.chromium.org/1240843004 Cr-Commit-Position: refs/heads/master@{#339276}

…hat seem to pass as-is. (patchset #2 id:20001 of https://codereview.chromium.org/1246863002/) Reason for revert: Got a signed/unsigned mismatch warning on GPU Win Builder (gtffixedtestvertexorder.c:58). Reverting change to gles2_conform_test.gyp; other files not reverted. Original issue's description: > Enable MSVC warning C4018 for various directories that seem to pass as-is. > > BUG=398202 > TEST=none > TBR=brettw > > Committed: https://crrev.com/513df87e8724587dc7be0d27a5f79652275c0767 > Cr-Commit-Position: refs/heads/master@{#339602} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=398202 Review URL: https://codereview.chromium.org/1242333005 Cr-Commit-Position: refs/heads/master@{#339606}

This results in incorrect context menu positioning in pdf in webview or webview inside appview. If a guest A is nested within an embedder B, which in turn is nested inside an embedder C, then we used to add offset twice to calculate the bounds of A because BrowserPluginGuest::GetScreenCoordinates would add: 1. offset of C from A and 2. offset of B from A. This CL removes step #2. From logs, it seems to be there from the beginning of appview implementation. BUG=507223 Test=Load a PDF inside <webview> and check context menu inside the PDF. Easier to test with the browser sample: https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/webview-samples/browser You should observe the context menu is shown in the right place instead of it being shifted. Review URL: https://codereview.chromium.org/1237343002 Cr-Commit-Position: refs/heads/master@{#339635}

…hset #2 id:20001 of https://codereview.chromium.org/1229853004/) Reason for revert: Reverting CL: it seems to cause regression in number of static initializers. For details see https://code.google.com/p/chromium/issues/detail?id=512348 Original issue's description: > Base: Make TimeDelta constructors deal with overflow. > > BUG=466445 > > Committed: https://crrev.com/15462e858ebf34721e28a023b0b670c2011183ac > Cr-Commit-Position: refs/heads/master@{#339605} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466445 Review URL: https://codereview.chromium.org/1250453004 Cr-Commit-Position: refs/heads/master@{#339641}

This CL parses the report-uri attribute on HPKP headers and stores them in TransportSecurityPersister. This is CL #1. CL #2: crrev.com/1212973002 (add net::CertificateReportSender) CL #3: crrev.com/1212613004 (add net::TransportSecurityReporter) CL #4: crrev.com/1213783005 (send HPKP reports) BUG=445793 Review URL: https://codereview.chromium.org/1211363005 Cr-Commit-Position: refs/heads/master@{#339667}

… (patchset #2 id:20001 of https://codereview.chromium.org/1241333002/) Reason for revert: This patch broke the mips builder for Android ../../third_party/lss/linux_syscall_support.h:121:21: fatal error: sgidefs.h: No such file or directory #include <sgidefs.h> Original issue's description: > Fix ProcessUtilTest.GetTerminationStatusCrash on Android L+ > > On Android L+, signal and sigaction symbols are provided by libsigchain > that override the system's versions. There is a bug in these functions > where they essentially ignore requests to install SIG_DFL. This causes > ProcessUtilTest.GetTerminationStatusCrash to fail (as > CrashingChildProcess goes into infinite loop instead of crashing). > > Workaround this issue by explicitly performing a syscall to > __NR_rt_sigaction to install SIG_DFL on Android, as breakpad does > (see https://breakpad.appspot.com/1804002/). > > BUG=512255 > TEST=ProcessUtilTest.GetTerminationStatusCrash > > Committed: https://crrev.com/31510fe3e2d3b1f3123f391db52372b2506c46ca > Cr-Commit-Position: refs/heads/master@{#339584} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=512255 Review URL: https://codereview.chromium.org/1247023002 Cr-Commit-Position: refs/heads/master@{#339668}

… of https://codereview.chromium.org/1242373002/) Reason for revert: Landed wrong patchset. Original issue's description: > Implements RLZTrackerDelegate on iOS. > > BUG=511570 > > Committed: https://crrev.com/8ff2e5ea76f4aed908188f0368ccb12d290236a7 > Cr-Commit-Position: refs/heads/master@{#339676} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=511570 Review URL: https://codereview.chromium.org/1250693003 Cr-Commit-Position: refs/heads/master@{#339685}

…ster (patchset #11 id:200001 of https://codereview.chromium.org/1211363005/) Reason for revert: Causes Win7 to hang Original issue's description: > Parse HPKP report-uri and persist in TransportSecurityPersister > > This CL parses the report-uri attribute on HPKP headers and stores them > in TransportSecurityPersister. > > This is CL #1. > CL #2: crrev.com/1212973002 (add net::CertificateReportSender) > CL #3: crrev.com/1212613004 (add net::TransportSecurityReporter) > CL #4: crrev.com/1213783005 (send HPKP reports) > > BUG=445793 > > Committed: https://crrev.com/1320e36d908427d615357df1630348bfb38cb5c4 > Cr-Commit-Position: refs/heads/master@{#339667} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=445793 Review URL: https://codereview.chromium.org/1249823002 Cr-Commit-Position: refs/heads/master@{#339759}

Summary of changes available at: https://chromium.googlesource.com/skia/+log/ae3714f..db0b1e7 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel [email protected] Commits in this roll: db0b1e7 [email protected] ANGLE deps roll 0f38612 [email protected] Bilinear optimization for 1D convolution. e59524d [email protected] make mixedtextblobs gm portable 4c4b84c [email protected] Clean up more SkXfermode.cpp dead code. 7e7b5c5 [email protected] adding assert to GrAtlasTextContext cd1930d [email protected] De-templatize Sk4pxXfermode code a bit. c3dcb67 [email protected] make color emoji gm portable 654ad19 [email protected] Revert of De-templatize Sk4pxXfermode code a bit. (patchset #2 id:20001 of https://codereview.chromium.org/1242743004/) 18c58c7 [email protected] Possible fix Moto E compilation failure e617e15 [email protected] De-templatize Sk4pxXfermode code a bit. cf2a6a4 [email protected] Reenable yasm for Android x86 and x86-64 on Linux host 259fbf1 [email protected] Add sanity check to GrAtlasTextBlob f6e092a [email protected] Remove SK_LEGACY_IMAGE_FILTER_CROP_RECT_EDGES code. Review URL: https://codereview.chromium.org/1248003002 Cr-Commit-Position: refs/heads/master@{#339760}

…://codereview.chromium.org/1223393003/) Reason for revert: This codepath is actually flaky. OnLoadedShader() races with dynamic GL binding initialization. Previously it meant that we just might not end up loading this shader (as long as b_GL_OES_get_program_binary etc. default to false), but the GetGLVersionInfo() might actually crash. Original issue's description: > gpu: Use shader cache on ES3 > > The ES3 core specs supports gl(Get)ProgramBinary(). > BUG=510172 > > Committed: https://crrev.com/809d9b979c0edd3976132eaaf77fc4740fcee019 > Cr-Commit-Position: refs/heads/master@{#339369} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510172,512464 Review URL: https://codereview.chromium.org/1247233002 Cr-Commit-Position: refs/heads/master@{#339802}

…chset #2 id:20001 of https://codereview.chromium.org/1245003002/) Reason for revert: Causing crash: crbug.com/512837 Original issue's description: > Potential fix for browser crash while ChromeVox is on. > > BUG=512000 > TEST=navigate to the launcher without and then with ChromeVox on. No crashes. > > Committed: https://crrev.com/22786b9f14a49d1bb0ddacbd9a9e343e482c23c9 > Cr-Commit-Position: refs/heads/master@{#339681} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=512000 Review URL: https://codereview.chromium.org/1247373002 Cr-Commit-Position: refs/heads/master@{#339887}

…tchset #2 id:40001 of https://codereview.chromium.org/1247243002/) Reason for revert: gclient runhooks started failing on Chromium OS (x86) Asan: http://build.chromium.org/p/chromiumos.chromium/builders/Chromium%20OS%20%28x86%29%20Asan/builds/7268 Relevant BuildPackages stdio extract: chromeos-chrome-46.0.2463.0_alpha-r1: Updating projects from gyp files... chromeos-chrome-46.0.2463.0_alpha-r1: gyp: Unable to find targets in build file /home/chrome-bot/chrome_root/src/remoting/app_remoting_shared_module.gyp chromeos-chrome-46.0.2463.0_alpha-r1: Error: Command /usr/bin/python2.7 src/build/gyp_chromium returned non-zero exit status 1 in /home/chrome-bot/chrome_root Original issue's description: > This CL switches the App Streaming shared module to use PNaCl. > Note that we cannot fix that for GN builds yet as there is > currently no GN toolchain for PNaCl > > BUG=511468 > > Committed: https://crrev.com/65761df9c25644233081e27d6253155b226a2e9a > Cr-Commit-Position: refs/heads/master@{#339967} [email protected],[email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=511468 Review URL: https://codereview.chromium.org/1248223002 Cr-Commit-Position: refs/heads/master@{#339993}

#2 id:20001 of https://codereview.chromium.org/1214863018/) Reason for revert: This might no longer be necessary according to cbieneman. Reverting to give that a try. Original issue's description: > Fix Clang update step on Windows after LLVM r242705 > > tools/CMakeLists.txt upstream has been updated to be more clever > and automagic about how it picks up dependencies to build in > tools. Unfortunately, this means that the clang target was not > defined before chrometools, which led to build errors. > > BUG=507826 [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507826 Review URL: https://codereview.chromium.org/1255723002 Cr-Commit-Position: refs/heads/master@{#340163}

sdroege · 2015-08-06T22:43:06Z

Firefox already supports GStreamer and uses it on Linux by default (and can use it on OSX/Windows if you compile it yourself).

This CL parses the report-uri attribute on HPKP headers and stores them in TransportSecurityPersister. This is CL #1. CL #2: crrev.com/1212973002 (add net::CertificateReportSender) CL #3: crrev.com/1212613004 (build and send HPKP reports) BUG=445793 Committed: https://crrev.com/1320e36d908427d615357df1630348bfb38cb5c4 Cr-Commit-Position: refs/heads/master@{#339667} Review URL: https://codereview.chromium.org/1211363005 Cr-Commit-Position: refs/heads/master@{#340490}

net::CertificateReportSender contains code factored out of CertificateErrorReporter in //chrome. net::CertificateReportSender will be used for both HPKP violation reports and the Safe Browsing Extended Reporting cert reports that CertificateErrorReporter handles. CL #1: crrev.com/1211363005 (parse report-uri) This is CL #2. CL #3: crrev.com/1212613004 (build and send HPKP reports) BUG=445793 Review URL: https://codereview.chromium.org/1212973002 Cr-Commit-Position: refs/heads/master@{#340641}

…id:160001 of https://codereview.chromium.org/1153913005/) Reason for revert: Breaks startup. Original issue's description: > Introduce abstraction for prune state storage. > > BUG=496744 > > Committed: https://crrev.com/9cd698b16f69e4cd19a96c1b1592677fc4671b08 > Cr-Commit-Position: refs/heads/master@{#340476} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=496744 Review URL: https://codereview.chromium.org/1254383004 Cr-Commit-Position: refs/heads/master@{#340667}

This CL adds code to TransportSecurityState to build HPKP reports, and sends them with a CertificateReportSender constructed by ProfileIOData. Calls to CheckPublicKeyPins() indicate whether a report should be sent and pass necessary reporting information as arguments. CL #1: crrev.com/1211363005 (parse report-uri) CL #2: crrev.com/1212973002 (add net::CertificateReportSender) This is CL #3. BUG=445793 Review URL: https://codereview.chromium.org/1212613004 Cr-Commit-Position: refs/heads/master@{#340687}

…et. (patchset #2 id:20001 of https://codereview.chromium.org/1250653002/) Reason for revert: Failing on all perf bots. https://code.google.com/p/chromium/issues/detail?id=514742 Original issue's description: > Enable out-of-process iframes benchmark using custom page set. > > Since out-of-process iframes have different characteristics for memory > usage and page load times, we should have a separate basic page set to > have more control over performance measurements. > > This CL adds such a page set and re-enables the benchmark. It also adds > another benchmark that executes without out-of-process iframes enabled > with the same new page set, which will allow us to compare regular Chrome > vs out-of-process enabled Chrome. > > BUG=462323 > > Committed: https://crrev.com/f558eec2af3294c4fdb9bb8094567ad73edd1a84 > Cr-Commit-Position: refs/heads/master@{#340592} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462323 Review URL: https://codereview.chromium.org/1262663002 Cr-Commit-Position: refs/heads/master@{#340739}

…hset #2 id:20001 of https://codereview.chromium.org/1265503002/) Reason for revert: It's breaking the VS2015 builder. I'm looking at it. Original issue's description: > win 2015: Update the toolchain package to VS2015 RTM. > > I've tried it locally (build Chrome with this archive on a fresh VM) and it worked well, the archive has been generated with package_from_installed.py (from depot_tools/win_toolchain) > > BUG= > > Committed: https://crrev.com/f04ff85d2b85833971ef7ca7f31f4fd5a1b1f3aa > Cr-Commit-Position: refs/heads/master@{#340898} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1254023004 Cr-Commit-Position: refs/heads/master@{#340906}

…0 SDK. (patchset #2 id:20001 of https://codereview.chromium.org/1246743003/) Reason for revert: Causes gclient runhooks to fail on bots that don't have the 10.10 SDK (even though they don't need to compile) Original issue's description: > mac: Switch the default build configuration to use the 10.10 SDK. > > This change is intended to be temporary. The goal is to release a Canary > compiled against the 10.10 SDK, and then to revert this CL. > > BUG=463170 > > Committed: https://crrev.com/42ba22e0b8e87f758804537f64db23ff6438e451 > Cr-Commit-Position: refs/heads/master@{#340992} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463170 Review URL: https://codereview.chromium.org/1254123003 Cr-Commit-Position: refs/heads/master@{#341003}

Summary of changes available at: https://chromium.googlesource.com/skia/+log/1864bfa..4f19ca3 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel [email protected] Commits in this roll: 4f19ca3 [email protected] Dont try to draw glyphs with unexpected mask formats ef004e1 [email protected] Remove SK_LEGACY_IMAGE_GENERATOR_ENUMS_AND_OPTIONS 6cb3cbe [email protected] Make GrGpu read/write pixels take GrSurface 8317a18 [email protected] Lay groundwork for SkOpts. dbf9f01 [email protected] buildbot_spec: Add configuration, do_*_steps, upload_*_results, more env 6fbd79e [email protected] Revert of Optimize RGB16 blitH functions with NEON for ARM platform. (patchset #2 id:20001 of https://codereview.chromium.org/1229673008/) Review URL: https://codereview.chromium.org/1263853003 Cr-Commit-Position: refs/heads/master@{#341130}

It's currently possible to "lose" a tab-modal dialog (e.g. print preview) when dragging multiple tabs off a browser. Mac's ConstrainedWindowManager doesn't support reparenting tab-modal dialogs, so dragging of tabs with modal dialogs must be prevented. BUG=514937 TEST=Have 3 tabs, press Cmd+P in #3 get a print preview, Shift+Click tab #2 (release mouse button), now drag tab #2 off the window. The whole window should drag (tabs can not be detached with dialogs). Before this change, the tabs would come off and the dialog would be lost. Review URL: https://codereview.chromium.org/1261513005 Cr-Commit-Position: refs/heads/master@{#341239}

…ent_traits.cc (patchset #2 id:20001 of https://codereview.chromium.org/1248383002/) Reason for revert: Breaks plugin placeholder context menu: https://code.google.com/p/chromium/issues/detail?id=514886 https://code.google.com/p/chromium/issues/detail?id=515730 Sry I have to revert this. Original issue's description: > Remove .windowX from ChromePluginPlaceholder & web_input_event_traits.cc > > All uses of the affected values are for window coordinates, see the > bug for details. One apparent exception was ShellWindowDelegateView but > it turns out that the coordinate there is actually a window coodinate; > we renamed a variable to clarify. > > This CL is on our way to nuke the redundant WebMouseEvent.windowX and > .windowY fields. > > BUG=507787 > > Committed: https://crrev.com/0587853ebbb4a79937fe05ff57d6847d50660b95 > Cr-Commit-Position: refs/heads/master@{#340463} [email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507787 Review URL: https://codereview.chromium.org/1258833003 Cr-Commit-Position: refs/heads/master@{#341550}

…nstead of a dict. (patchset #2 id:280001 of https://codereview.chromium.org/1262623007/ ) Reason for revert: fails reliably on XP tests: https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(1)/builds/39209/steps/telemetry_perf_unittests/logs/stdio Original issue's description: > Reland of Create classes_util API, change discover to return a list instead of a dict. (patchset #1 id:1 of https://codereview.chromium.org/1263063003/) > > Reason for revert: > The telemetry tests aren't broken. The perf_unittests are because they don't pick tests in a deterministic way. Reverting after a change to make them deterministic. > > Original issue's description: > > Revert of Create classes_util API, change discover to return a list instead of a dict. (patchset #5 id:120001 of https://codereview.chromium.org/1244223002/) > > > > Reason for revert: > > This appears to break the XP telemetry tests. Details on the bug. > > > > Original issue's description: > > > Create classes_util API, change discover to return a list instead of a dict. > > > > > > BUG=498968 > > > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > > > > > Committed: https://crrev.com/e6cbec4747aa7fe3c96b1cdb89de21ae77b30ab0 > > > Cr-Commit-Position: refs/heads/master@{#341129} > > > > [email protected],[email protected],[email protected] > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=498968 > > > > Committed: https://crrev.com/c85e3e1af7e170d5f8ec2b012df6e9337d2352bb > > Cr-Commit-Position: refs/heads/master@{#341218} > > [email protected],[email protected],[email protected] > BUG=498968 > > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/7e6fefcf3b839256c97e2e7bc0bfc3c53af75c8d > Cr-Commit-Position: refs/heads/master@{#341646} [email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=498968 Review URL: https://codereview.chromium.org/1267243002 Cr-Commit-Position: refs/heads/master@{#341692}

#2 id:20001 of https://codereview.chromium.org/1270743005/ ) Reason for revert: This is causing the Linux perf bot to consistently time out on start_with_ext.warm.blank_page. See issue 516623 for more information. Original issue's description: > Enable start_with_ext benchmark on Linux platforms. > > BUG=513881 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/3b9444d1d42eb518bfb199d6b622d0b9ff0b4acf > Cr-Commit-Position: refs/heads/master@{#341596} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=513881 Review URL: https://codereview.chromium.org/1262053005 Cr-Commit-Position: refs/heads/master@{#341707}

Summary of changes available at: https://chromium.googlesource.com/skia/+log/093b4e8..1cd6311 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel [email protected] Commits in this roll: 1cd6311 [email protected] init atomic bool in SkImage_Gpu 9162ea9 [email protected] Revert of Break LCD and Bitmap text dependency on hardcoded atlas values (patchset #2 id:20001 of https://codereview.chromium.org/1271873002/ ) b356cbc [email protected] Move atlas creation to internal to GrResourceProvider Review URL: https://codereview.chromium.org/1269263005 Cr-Commit-Position: refs/heads/master@{#341902}

…sagePortService. (patchset #2 id:60001 of https://codereview.chromium.org/1224263007/ ) Reason for revert: Seems to be crashing on windows. BUG=517281 Original issue's description: > Refactor browser side navigator.connect code to not use MessagePortService. > > This is the first step towards unifying client side and service side ServicePort > instances, but also removes a layer of abstraction in how connections to > services are setup. The abstraction layer will probably later be reintroduced > differently. > > BUG=426458 > > Committed: https://crrev.com/9b053ed8f7b8893ad0a5a33d31546c70563ddf20 > Cr-Commit-Position: refs/heads/master@{#341987} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=426458 Review URL: https://codereview.chromium.org/1278483004 Cr-Commit-Position: refs/heads/master@{#342026}

…nt memory overhead (patchset #2 id:110001 of https://codereview.chromium.org/1258903003/ ) Reason for revert: Reverting did not solve crbug.com/516056 Original issue's description: > Revert of [tracing] Fix, simplify and speed up accounting of TraceEvent memory overhead (patchset #4 id:60001 of https://codereview.chromium.org/1251203003/ ) > > Reason for revert: > Speculative revert for https://code.google.com/p/chromium/issues/detail?id=516056 > > Original issue's description: > > [tracing] Fix, simplify and speed up accounting of TraceEvent memory overhead > > > > So far the accounting of TraceEvent memory overhead worked as follows: > > - Each TraceEvent keeps a cache of its own overhead. > > - The TraceBufferChunk (which is approx an array of 64 TraceEvent) > > keeps a cache of the all 64 TraceEvent, but only when completelly > > filled. > > > > This is sub-optimal because: > > - There can be many TraceEvent(s), 10k-100k in a bulky 30s trace: > > when memory-infra is enabled, this causes a cost of several MB to > > keep the aforementioned per-TraceEvent caches. > > - Every time we have to estimate the size of a non-completely-full > > TraceBufferChunk, we still have to loop over their individual caches. > > - Least but not last, turns out that the current accounting is just > > wrong, as we ended up counting the sizeof(TraceEvent) both in > > TraceBufferChunk and in the individual TraceEvent. > > > > This CL improves the situation as follows: > > - The per-TraceEvent cache is dropped. Much less memory is used. > > - The TraceBufferChunk still keeps a cache, but its cache is used in a > > smarter way and not just when it is full. We simply remember how many > > TraceEvent(s) we estimated in the previous pass and then estimate just > > the missing ones. > > - The double accounting issue is fixed, as now we count TraceEvent(s) > > only in TraceBufferChunk. > > > > BUG=512383 > > > > Committed: https://crrev.com/b2ae97fb331cbad132a8e1aad9a25441fde75048 > > Cr-Commit-Position: refs/heads/master@{#340005} > > [email protected],[email protected] > BUG=512383 > > Committed: https://crrev.com/8f329fc15f5fa64f64308244266a304c122a2868 > Cr-Commit-Position: refs/heads/master@{#341910} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=512383 Review URL: https://codereview.chromium.org/1265393007 Cr-Commit-Position: refs/heads/master@{#342157}

Update this test to reflect the removal of twin updating. Instead of having tilings removed, tilings currently just stay stale if their layer owner is not in the RSLL and updated. The test was going to the next step before a pinch was complete, and so would sometimes end up with an extra draw from source frame 0 before the commit from source frame 1 would occur. This is easily repro'd by adding a sleep(1) to the draw function in the test. This is avoided by tracking NotifyReadyToDraw and only going to step #2 after the draw following it. [email protected],[email protected] BUG=460581 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1276683002 Cr-Commit-Position: refs/heads/master@{#342158}

…er mode changes (patchset #2 id:20001 of https://codereview.chromium.org/1275663003/ ) Reason for revert: Suspect it broke Linux ChromiumOS Tests https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/7163 BasicExtensionSettingsWebUITest.testDeveloperModeManyExtensions (run #2): [ RUN ] BasicExtensionSettingsWebUITest.testDeveloperModeManyExtensions [23730:23730:0806/145316:WARNING:chrome_browser_main_chromeos.cc(290)] Running as stub user with profile dir: test-user [23730:23730:0806/145316:INFO:audio_manager_pulse.cc(258)] Failed to connect to the context. Error: Connection refused Xlib: extension "RANDR" missing on display ":9". [23730:23762:0806/145316:WARNING:local_extension_cache.cc(260)] Extensions will not be installed from update URLs until /var/cache/external_cache/.initialized exists. [23730:23730:0806/145316:WARNING:child_account_service.cc(292)] User instance wasn't found while setting child account flag. [23730:23746:0806/145316:WARNING:freezer_cgroup_process_manager.cc(58)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [23730:23730:0806/145316:ERROR:device_event_log_impl.cc(167)] [14:53:16.756] USB: usb_service_impl.cc:541 Failed to initialize libusb: Other error [23730:23730:0806/145316:INFO:CONSOLE(5)] "line1", source: chrome-extension://pdlpifnclfacjobnmbpngemkalkjamnf/script.js (5) [23730:23730:0806/145316:INFO:CONSOLE(6)] "line2", source: chrome-extension://pdlpifnclfacjobnmbpngemkalkjamnf/script.js (6) [23730:23730:0806/145317:WARNING:CONSOLE(0)] "/deep/ combinator is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source: (0) [23730:23730:0806/145317:INFO:CONSOLE(1324)] "Running TestCase BasicExtensionSettingsWebUITest.testDeveloperModeManyExtensions", source: test_api.js (1324) [23730:23730:0806/145317:ERROR:CONSOLE(0)] "Error in response to developerPrivate.getProfileConfiguration: Error: Test Error assertTrue(this.steps.length > 0): false", source: chrome://extensions-frame/ (0) [23730:23730:0806/145317:ERROR:CONSOLE(0)] "Error in response to developerPrivate.getProfileConfiguration: Error: Test Error assertTrue(this.steps.length > 0): false", source: chrome://extensions-frame/ (0) [23730:23730:0806/145317:ERROR:web_ui_browser_test.cc(455)] Encountered javascript console error(s) obj/chrome/browser_tests.gen/chrome/browser/ui/webui/extensions/extension_settings_browsertest-gen.cc:46: Failure Value of: RunJavascriptTestF(true, "BasicExtensionSettingsWebUITest", "testDeveloperModeManyExtensions") Actual: false Expected: true [ FAILED ] BasicExtensionSettingsWebUITest.testDeveloperModeManyExtensions, where TypeParam = and GetParam() = (837 ms) Original issue's description: > [Extensions Page] Send a profile changed event when developer mode changes > > Developer mode can affect the presence of certain items on the page, like the > collect errors checkbox. Send an event notifying of the profile change when this > happens. > > BUG=516583 > > Committed: https://crrev.com/34644bb031a339d2897c210f228e633e0999a11b > Cr-Commit-Position: refs/heads/master@{#342192} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=516583 Review URL: https://codereview.chromium.org/1277083002 Cr-Commit-Position: refs/heads/master@{#342226}

LifeIsStrange · 2015-08-08T22:52:36Z

Oh thank you sdroege !
Also sorry an other question who take your time (you are not obligated ton answer me) gstreamer have à Daala draft implementation ?

sdroege · 2015-08-09T13:51:59Z

@LifeIsStrange yeah, I wrote one a few years ago here: http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/daala
I don't know if it compiles against the latest Daala API, it probably needs some updates.

Update: Actually it still compiles and just works with latest Daala

sdroege · 2015-08-09T13:52:57Z

Note that Daala is not production ready yet, and that streams you create now are most likely not going to work with the final format.

LifeIsStrange · 2015-08-10T00:47:38Z

OK thank you so much sdroege ! And I know that Daala still need one year of stabilisation :)

sdroege · 2015-08-10T08:33:00Z

If you want to discuss more GStreamer related things, better let's move this to the GStreamer developers mailing list here: http://gstreamer.freedesktop.org/lists/

LifeIsStrange · 2015-08-11T01:43:45Z

Yes, thanks !

JulienIsorce · 2015-10-28T16:28:09Z

Thx for your remarks, if you have further request please open a new issue.

JulienIsorce pushed a commit that referenced this issue Jul 17, 2015

Clean up src-side runtest.py, patch #2 (remove log scraping)

a8ca453

BUG=506498 Review URL: https://codereview.chromium.org/1225563004 Cr-Commit-Position: refs/heads/master@{#337381}

JulienIsorce closed this as completed Oct 28, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Awesome but chrome is full of backdoors.... #2

Awesome but chrome is full of backdoors.... #2

LifeIsStrange commented Jul 12, 2015

sdroege commented Aug 6, 2015

LifeIsStrange commented Aug 8, 2015

sdroege commented Aug 9, 2015

sdroege commented Aug 9, 2015

LifeIsStrange commented Aug 10, 2015

sdroege commented Aug 10, 2015

LifeIsStrange commented Aug 11, 2015

JulienIsorce commented Oct 28, 2015

Awesome but chrome is full of backdoors.... #2

Awesome but chrome is full of backdoors.... #2

Comments

LifeIsStrange commented Jul 12, 2015

sdroege commented Aug 6, 2015

LifeIsStrange commented Aug 8, 2015

sdroege commented Aug 9, 2015

sdroege commented Aug 9, 2015

LifeIsStrange commented Aug 10, 2015

sdroege commented Aug 10, 2015

LifeIsStrange commented Aug 11, 2015

JulienIsorce commented Oct 28, 2015