Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What should happen if you pass multiple of the same DieSide to a CustomDie? #56

Open
Samasaur1 opened this issue Jun 25, 2019 · 0 comments
Open

What should happen if you pass multiple of the same DieSide to a CustomDie? #56

Samasaur1 opened this issue Jun 25, 2019 · 0 comments
Labels
question Further information is requested

Comments

@Samasaur1
Copy link
Owner

This would effectively weigh the die, which would impact #52. But the question is, should CustomDie allow that and check for it in the chance(of:) method, or should it filter out duplicates in the initializer?

Right now, it allows it and checks in the (upcoming) chance(of:) method
@Samasaur1 Samasaur1 added the question Further information is requested label Jun 25, 2019
Samasaur1 added a commit that referenced this issue Jun 25, 2019
@Samasaur1
Add chance functions (closes #4) (see #56)
6fc796f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Samasaur1