Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node.js <= 4 #99

Merged
merged 2 commits into from
May 14, 2018

Conversation

sudo-suhas
Copy link
Contributor

  • Update engines field in package.json.
  • Update Travis and Appveyor CI config, do not test node 4.

Let me know if there are any other changes you'd like me to do.

Closes #98

Verified

This commit was signed with the committer’s verified signature.
nalimilan Milan Bouchet-Valat
- Update engines field in package.json.
- Update Travis and Appveyor CI config, do not test node 4.
@SamVerschueren
Copy link
Owner

Set XO version to '*' and fix code accordingly.

@codecov-io
Copy link

codecov-io commented May 13, 2018

Codecov Report

Merging #99 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files           7        7           
  Lines         190      190           
=======================================
  Hits          183      183           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5880368...dbdecff. Read the comment docs.

SamVerschueren
SamVerschueren approved these changes May 14, 2018
@SamVerschueren SamVerschueren merged commit b3d4abe into SamVerschueren:master May 14, 2018
@sudo-suhas sudo-suhas deleted the drop-node-4-support branch May 14, 2018 05:27
@SamVerschueren
Copy link
Owner

Thanks @sudo-suhas 🎉!

@sudo-suhas
Copy link
Contributor Author

My pleasure @SamVerschueren 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants