Skip nvm aliases when checking supported versions

SamVerschueren · Jan 26, 2017 · b0179d0 · b0179d0
1 parent dc90ac0
commit b0179d0
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 0 deletions.
diff --git a/rules/travis.js b/rules/travis.js
@@ -3,6 +3,7 @@ const semver = require('semver');
 
 const SUPPORTED_VERSIONS = ['0.10', '0.12', '4', '6'];
 const DEPRECATED_VERSIONS = ['iojs', 'stable'];
+const NVM_ALIASES = ['node', 'iojs', 'stable', 'unstable'];
 
 /**
  * Normalize a semantic version to be a valid version. 0.10 -> 0.10.0
@@ -21,6 +22,10 @@ const normalize = version => {
 
 const isSupported = (version, engines) => {
 	for (const engine of engines) {
+		if (NVM_ALIASES.indexOf(engine) !== -1) {
+			continue;
+		}
+
 		if (semver.satisfies(normalize(engine), version)) {
 			return true;
 		}

diff --git a/test/fixtures/travis/alias/.travis.yml b/test/fixtures/travis/alias/.travis.yml
@@ -0,0 +1,5 @@
+language: node_js
+node_js:
+  - 'node'
+  - '6'
+  - '4'
diff --git a/test/fixtures/travis/alias/package.json b/test/fixtures/travis/alias/package.json
@@ -0,0 +1,6 @@
+{
+  "name": "travis",
+  "engines": {
+    "node": ">=4"
+  }
+}
diff --git a/test/travis.js b/test/travis.js
@@ -106,6 +106,10 @@ test('untested versions', async t => {
 	);
 });
 
+test('nvm alias', async t => {
+	await ruleTester(t, 'alias', []);
+});
+
 test('deprecated versions', async t => {
 	const file = path.resolve(opts.cwd, 'deprecated/.travis.yml');