Skip to content

Commit

Permalink
ci: fix incorrect github credetials (angular#15146)
Browse files Browse the repository at this point in the history
  • Loading branch information
mhevery authored and SamVerschueren committed Mar 18, 2017
1 parent 49a797d commit 7edab36
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ env:
global:
# GITHUB_TOKEN_ANGULAR=<github token, a personal access token of the angular-builds account, account access in valentine>
# This is needed for the e2e Travis matrix task to publish packages to github for continuous packages delivery.
- secure: "PJXJptSS0ukNH4rxXpLFQ4wLxY/uiyFz0V5VQysM9adYu4tebqwP5fzZp6pb7IdYMJKaW9Lw1R9VGcV0dWqr4blf/H3MMc4Y6z18cPq+j56WoM5sgsDo5lRlsCC0g63TZUuBKQhKE2WQgAERJebCQSDkFyPi88Qmph6fkP3bbjg="
- secure: "rNqXoy2gqjbF5tBXlRBy+oiYntO3BtzcxZuEtlLMzNaTNzC4dyMOFub0GkzIPWwOzkARoEU9Kv+bC97fDVbCBUKeyzzEqxqddUKhzRxeaYjsefJ6XeTvBvDxwo7wDwyxZSuWdBeGAe4eARVHm7ypsd+AlvqxtzjyS27TK2BzdL4="
# FIREBASE_TOKEN
# This is needed for publishing builds to the "aio-staging" firebase site.
# TODO(i): the token was generated using the iminar@google account, we should switch to a shared/role-base account.
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/publish-build-artifacts.sh
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ function publishRepo {
cd $REPO_DIR && \
git config credential.helper "store --file=.git/credentials" && \
# SECURITY CRITICAL: DO NOT use shell to expand vars since it could be logged and leaked.
node -e "console.log('https://'+process.env.GITHUB_TOKEN_ANGULAR+':github.com')" > .git/credentials
node -e "console.log('https://'+process.env.GITHUB_TOKEN_ANGULAR+':@github.com')" > .git/credentials
)
fi
echo `date` > $REPO_DIR/BUILD_INFO
Expand Down

0 comments on commit 7edab36

Please sign in to comment.