Testing auto-gen docs for DataFrame #230

DivvyCr · 2020-04-18T12:31:23Z

added optional clean flag to analyze_replay_file(). Default is True.

analysis_manager.py cleaner.py frame_cleaner.py (improved readability)

…an a replay before analysis.

…y added as SHORT_SAMPLE). Flagged analyze_replay_file with clean=True.

dtracers · 2020-04-18T14:37:42Z

carball/json_parser/game.py

        self.file_path = file_path
+        self.load_json(loaded_json)


Is this just moving everything into a different function?

Yeah - It makes it much easier to read, imo?
I also split up the properties into multiple functions for the same purpose.. All the validity checks made it really hard to get the idea of what's happening

after you get the tests working you should check the performance to make sure it is not massively slower.

I've never heard of split functions hindering performance - it just passes parameters, and python has low overhead for making method calls (as well as most other langs)

carball/tests/docs/df_methods.txt

carball/tests/docs/df_summary.txt

AppVeyorBot · 2020-04-18T20:46:33Z

❌ Build carball 0.6.43-fhbvldtd failed (commit 8e658387a7 by @dtracers)

AppVeyorBot · 2020-04-18T20:46:34Z

❌ Build carball 0.6.43-fhbvldtd failed (commit 8e658387a7 by @dtracers)

AppVeyorBot · 2020-04-18T21:19:54Z

❌ Build carball 0.6.43-ffsooeoo failed (commit 13849cbbe3 by @DivvyC)

AppVeyorBot · 2020-04-18T21:19:55Z

❌ Build carball 0.6.43-ffsooeoo failed (commit 13849cbbe3 by @DivvyC)

These methods should not be visible to the external user.

AppVeyorBot · 2020-04-19T05:44:59Z

❌ Build carball 0.6.43-tsbcdvbx failed (commit 032b36cb87 by @dtracers)

AppVeyorBot · 2020-04-19T05:45:00Z

❌ Build carball 0.6.43-tsbcdvbx failed (commit 032b36cb87 by @dtracers)

AppVeyorBot · 2020-04-19T05:51:06Z

❌ Build carball 0.6.43-cloearyt failed (commit 56b63a844b by @dtracers)

AppVeyorBot · 2020-04-19T05:51:06Z

❌ Build carball 0.6.43-cloearyt failed (commit 56b63a844b by @dtracers)

lgtm-com · 2020-04-19T05:54:39Z

This pull request introduces 1 alert and fixes 1 when merging c2aa2f2 into b5a673e - view on LGTM.com

new alerts:

1 for Signature mismatch in overriding method

fixed alerts:

1 for Wrong number of arguments in a call

AppVeyorBot · 2020-04-19T06:24:03Z

✅ Build carball 0.6.43-rlhoehxs completed (commit 7896078721 by @dtracers)

AppVeyorBot · 2020-04-19T06:24:04Z

✅ Build carball 0.6.43-rlhoehxs completed (commit 7896078721 by @dtracers)

codecov · 2020-04-19T06:26:03Z

Codecov Report

Merging #230 into master will increase coverage by 1.16%.
The diff coverage is 90.32%.

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   89.83%   91.00%   +1.16%     
==========================================
  Files         100      100              
  Lines        4555     4567      +12     
  Branches      778      782       +4     
==========================================
+ Hits         4092     4156      +64     
+ Misses        335      281      -54     
- Partials      128      130       +2

lgtm-com · 2020-04-19T06:26:24Z

This pull request fixes 1 alert when merging c090fa3 into b5a673e - view on LGTM.com

fixed alerts:

1 for Wrong number of arguments in a call

AppVeyorBot · 2020-04-19T06:37:53Z

✅ Build carball 0.6.43-etycibap completed (commit a2e090fff5 by @dtracers)

AppVeyorBot · 2020-04-19T06:37:54Z

✅ Build carball 0.6.43-etycibap completed (commit a2e090fff5 by @dtracers)

AppVeyorBot · 2020-04-19T16:08:04Z

❌ Build carball 0.6.44-xbvmqpdp failed (commit 233c3912bb by @dtracers)

AppVeyorBot · 2020-04-19T16:08:05Z

❌ Build carball 0.6.44-xbvmqpdp failed (commit 233c3912bb by @dtracers)

lgtm-com · 2020-04-19T16:28:47Z

This pull request fixes 1 alert when merging 51ce723 into b5a673e - view on LGTM.com

fixed alerts:

1 for Wrong number of arguments in a call

AppVeyorBot · 2020-04-19T16:31:51Z

✅ Build carball 0.6.44-nxurxmlw completed (commit 77efde99e7 by @dtracers)

AppVeyorBot · 2020-04-19T16:31:52Z

✅ Build carball 0.6.44-nxurxmlw completed (commit 77efde99e7 by @dtracers)

lgtm-com · 2020-04-19T16:43:53Z

This pull request fixes 1 alert when merging 98eaf9a into b5a673e - view on LGTM.com

fixed alerts:

1 for Wrong number of arguments in a call

AppVeyorBot · 2020-04-19T16:46:43Z

✅ Build carball 0.6.44-bqfhgodi completed (commit ba1a9f947e by @DivvyC)

AppVeyorBot · 2020-04-19T16:46:44Z

✅ Build carball 0.6.44-bqfhgodi completed (commit ba1a9f947e by @DivvyC)

…to pr/230

lgtm-com · 2020-04-19T17:41:01Z

This pull request fixes 1 alert when merging 55f3a98 into b5a673e - view on LGTM.com

fixed alerts:

1 for Wrong number of arguments in a call

AppVeyorBot · 2020-04-19T17:43:47Z

✅ Build carball 0.6.44-jrsedkng completed (commit deff123621 by @dtracers)

AppVeyorBot · 2020-04-19T17:43:48Z

✅ Build carball 0.6.44-jrsedkng completed (commit deff123621 by @dtracers)

lgtm-com · 2020-04-21T16:59:46Z

This pull request fixes 1 alert when merging 05f2a93 into f08c711 - view on LGTM.com

fixed alerts:

1 for Wrong number of arguments in a call

AppVeyorBot · 2020-04-21T17:10:31Z

❌ Build carball 0.6.48-kiwivgss failed (commit a7f8852b1a by @dtracers)

AppVeyorBot · 2020-04-21T17:10:32Z

❌ Build carball 0.6.48-kiwivgss failed (commit a7f8852b1a by @dtracers)

AppVeyorBot · 2020-04-21T17:35:27Z

✅ Build carball 0.6.48-lukhdouk completed (commit a7f8852b1a by @dtracers)

AppVeyorBot · 2020-04-21T17:35:28Z

✅ Build carball 0.6.48-lukhdouk completed (commit a7f8852b1a by @dtracers)

DivvyC and others added 9 commits April 15, 2020 14:28

Docs

e2b3701

analysis_manager.py cleaner.py frame_cleaner.py (improved readability)

Small fix

4d936a2

Edited the docs slightly.

33a6d1b

Removed the if statement for equal team sizes (temp)

8270738

Merge branch 'master' into documentation

56e8dd6

Cleared up the intitialize() method. Added some docs.

4b49b68

Created 'clean' flag - True by default, that indicates whether to cle…

f79257c

…an a replay before analysis.

Created docs dir and written auto-gen docs for data frame (used repla…

4ad7fc4

…y added as SHORT_SAMPLE). Flagged analyze_replay_file with clean=True.

Fixed some random errors..

5f995a8

dtracers requested changes Apr 18, 2020

View reviewed changes

Merge branch 'master' into documentation

8ef441a

DivvyC added 2 commits April 18, 2020 22:12

File formats changed (.txt -> .md)

64cc452

Merge remote-tracking branch 'origin/documentation' into documentation

858eaa6

dtracers added 2 commits April 18, 2020 22:38

Made some methods "private"

2d9ceec

These methods should not be visible to the external user.

renamed file to run python correctly

c2aa2f2

dtracers added 3 commits April 18, 2020 23:02

reverted game.py

6f2664e

Fixed some minor bugs

bcd7c85

fixed lgtm issue

c090fa3

Added a check for file mode in the pandas

bf817ec

Added unit tests for checking file mode

51ce723

dtracers previously approved these changes Apr 19, 2020

View reviewed changes

Added docs for all write_X_to_file() methods.

98eaf9a

DivvyCr dismissed dtracers’s stale review via 98eaf9a April 19, 2020 16:31

dtracers added 2 commits April 19, 2020 10:28

run json tests

778091a

Merge branch 'documentation' of https://github.com/DivvyCr/carball in…

55f3a98

…to pr/230

Merge branch 'master' into documentation

05f2a93

dtracers approved these changes Apr 21, 2020

View reviewed changes

dtracers merged commit f8515c3 into SaltieRL:master Apr 21, 2020

Testing auto-gen docs for DataFrame #230

Testing auto-gen docs for DataFrame #230

Conversation

DivvyCr commented Apr 18, 2020

dtracers Apr 18, 2020

Choose a reason for hiding this comment

DivvyCr Apr 18, 2020

Choose a reason for hiding this comment

dtracers Apr 18, 2020

Choose a reason for hiding this comment

DivvyCr Apr 18, 2020 • edited Loading

Choose a reason for hiding this comment

AppVeyorBot commented Apr 18, 2020

AppVeyorBot commented Apr 18, 2020

AppVeyorBot commented Apr 18, 2020

AppVeyorBot commented Apr 18, 2020

AppVeyorBot commented Apr 19, 2020

AppVeyorBot commented Apr 19, 2020

AppVeyorBot commented Apr 19, 2020

AppVeyorBot commented Apr 19, 2020

lgtm-com bot commented Apr 19, 2020

AppVeyorBot commented Apr 19, 2020

AppVeyorBot commented Apr 19, 2020

codecov bot commented Apr 19, 2020 • edited Loading

Codecov Report

lgtm-com bot commented Apr 19, 2020

AppVeyorBot commented Apr 19, 2020

AppVeyorBot commented Apr 19, 2020

AppVeyorBot commented Apr 19, 2020

AppVeyorBot commented Apr 19, 2020

lgtm-com bot commented Apr 19, 2020

AppVeyorBot commented Apr 19, 2020

AppVeyorBot commented Apr 19, 2020

lgtm-com bot commented Apr 19, 2020

AppVeyorBot commented Apr 19, 2020

AppVeyorBot commented Apr 19, 2020

lgtm-com bot commented Apr 19, 2020

AppVeyorBot commented Apr 19, 2020

AppVeyorBot commented Apr 19, 2020

lgtm-com bot commented Apr 21, 2020

AppVeyorBot commented Apr 21, 2020

AppVeyorBot commented Apr 21, 2020

AppVeyorBot commented Apr 21, 2020

AppVeyorBot commented Apr 21, 2020

DivvyCr Apr 18, 2020 •

edited

Loading

codecov bot commented Apr 19, 2020 •

edited

Loading