Only push on master

Comment all the time
SaltieRL · May 1, 2020 · 81dbf11 · 81dbf11
1 parent bcc1a8c
commit 81dbf11
Showing 1 changed file with 19 additions and 1 deletion.
diff --git a/.github/workflows/benchmarking.yml b/.github/workflows/benchmarking.yml
@@ -45,8 +45,26 @@ jobs:
         cd carball/tests/benchmarking
         pytest benchmarking.py --benchmark-json carball_benchmarking.json -k 'test_${{matrix.benchtest}}'
 
+    # always comment on every push
+    - name: Process and store benchmark ${{matrix.benchtest}}.
+        uses: rhysd/github-action-benchmark@v1
+        with:
+          name: Carball Benchmarks ${{matrix.benchtest}}
+          tool: 'pytest'
+          output-file-path: carball/tests/benchmarking/carball_benchmarking.json
+          benchmark-data-dir-path: dev/bench/${{matrix.benchtest}}/
+          # Use personal access token instead of GITHUB_TOKEN due to
+          # https://github.community/t5/GitHub-Actions/Github-action-not-triggering-gh-pages-upon-push/td-p/26869/highlight/false
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          auto-push: false
+          alert-threshold: '125%' # If performance is 1.25x worse, there will be an alert
+          comment-always: true
+          fail-on-alert: true
+
     # REQUIRES gh-pages BRANCH IN THE MAIN REPO (for the graphs).
+    # Only upload to master branch on push
     - name: Process and store benchmark ${{matrix.benchtest}}.
+      if: contains(github.ref, 'master')
       uses: rhysd/github-action-benchmark@v1
       with:
         name: Carball Benchmarks ${{matrix.benchtest}}
@@ -58,5 +76,5 @@ jobs:
         github-token: ${{ secrets.GH_WIKI_EDIT_TOKEN }}
         auto-push: true
         alert-threshold: '125%' # If performance is 1.25x worse, there will be an alert
-        comment-always: true
+        comment-always: false
         comment-on-alert: true