Control Generator #110
Control Generator #110
Conversation
Generates controls from a list of replays.
| from carball.controls.controls import ControlsCreator | ||
| import numpy as np | ||
|
|
||
| class ReplayControlGen( BaseDataGenerator ): |
There was a problem hiding this comment.
can you add a doc comment about what this generates specifically?
| ControlsCreator().get_controls( game ) | ||
| return game | ||
|
|
||
| def sampleFrames( game, player, start, end ): |
There was a problem hiding this comment.
can you add return values for these?
| self.currentFrame = endFrame | ||
| return sampleFrames( self.game, player, startFrame, endFrame ) | ||
|
|
||
| def gameFromFile( replayName ): #Do not include file extension |
There was a problem hiding this comment.
can you add types + move your comment to a python doc comment?
Removed unessicary/clunky functionality, added doc comments
Added return and parameter types
| """ | ||
|
|
||
| def __init__(self, filepaths: list): | ||
| # filepaths:list of paths to replay files (no file extension), player: player index, frames: number of frames per output |
There was a problem hiding this comment.
put this inside the python docs or remove this comment
| return False | ||
| return True | ||
|
|
||
| def _next(self) -> list: |
There was a problem hiding this comment.
this should be List
and can be imported from typing
| return game | ||
|
|
||
|
|
||
| def getControls(player, frame: int) -> list: |
Fixed List typing, added player typing removed extraneous comments and added non-extraneous comments.
| pass | ||
|
|
||
| def has_next(self): | ||
| #If we are at the max frame, the last player and the last file then we have no more data to collect. |
There was a problem hiding this comment.
can we make this a python style comment
There was a problem hiding this comment.
I'm not sure what that means...
| """ | ||
| Gets the controls of a player at a frame | ||
| Arguments: | ||
| player -- player object, game.players[p] |
There was a problem hiding this comment.
this is not the python style i am normally used to seeing.
try this instead
https://stackoverflow.com/questions/9195455/how-to-document-a-method-with-parameters
example:
`
:player Player
Description of player
Upgraded the cool factor by 10%
Generates controls from a list of replays.