Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TWILIGHT-2544): add pnpm lock file and update package manager to pnpm #510

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Nabute
Copy link
Contributor

@Nabute Nabute commented Dec 29, 2024

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Feature: Added support for PNPM as the package manager and generated a lockfile.

What is the current behavior? (You can also link to an open issue here)

  • Currently, the project uses npm, and the lockfile is generated as package-lock.json, which can lead to larger disk usage and slower installs due to duplication of dependencies across projects.

What is the new behavior? (You can also link to the ticket here)

  • With this PR, the project switches to PNPM, which uses a global store for dependencies. The new pnpm-lock.yaml file ensures consistent dependency versions and faster installs.

Does this PR introduce a breaking change?

  • No, this PR does not introduce any breaking changes. The project can continue to run with the same dependencies, just managed more efficiently with PNPM.

Screenshots (If appropriate)

  • N/A

@SallaDev SallaDev marked this pull request as draft December 29, 2024 11:58
@Nabute Nabute changed the title chore: add pnpm lock file and update package manager to pnpm chore(TILIGHT-2544): add pnpm lock file and update package manager to pnpm Dec 29, 2024
@Nabute Nabute marked this pull request as ready for review December 29, 2024 11:59
@Nabute
Copy link
Contributor Author

Nabute commented Dec 29, 2024

/autoupdate

@SallaDev
Copy link
Contributor

The branch feature/TWILIGHT-2544-add-pnpm-support-new of #510 Branch is up-to-date..✅

pnpm-lock.yaml Show resolved Hide resolved
@Nabute Nabute changed the title chore(TILIGHT-2544): add pnpm lock file and update package manager to pnpm fix(TWILIGHT-2544): add pnpm lock file and update package manager to pnpm Dec 29, 2024
peerDependencies:
postcss: ^8.1.0

[email protected]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Codacy found a medium Security issue: Insecure dependency [email protected] (CVE-2023-45857: axios: exposure of confidential data stored in cookies) (update to 0.28.0)

The issue reported by the Trivy linter is related to a vulnerability in the axios library, specifically version 0.27.2, which has been flagged for exposing confidential data stored in cookies (CVE-2023-45857). The recommended action is to update the axios library to version 0.28.0 or later to mitigate this security risk.

To fix the issue, you should update the version of axios from 0.23.0 to 0.28.0 in your dependency list. Here is the code suggestion to make that change:

Suggested change
axios@0.23.0:
axios@0.28.0:

This comment was generated by an experimental AI tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants