fix(themes): Enhance product options validation in cart page #500
Conversation
|
/autoupdate |
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
| }); | ||
| } | ||
| }); | ||
| observer.observe(quantityComponent, { childList: true, subtree: true }); |
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: subtree on Identifier
The issue reported by the ESLint linter indicates that the word "subtree" is misspelled in the identifier within the observer.observe method call. This is likely a false positive, as "subtree" is a valid option in the MutationObserver API, but the linter might be configured with a custom dictionary that does not recognize it.
To address the issue, you can add a comment to disable the specific ESLint rule for that line, which will prevent the linter from flagging it as an error. Here’s the suggested code change:
| observer.observe(quantityComponent, { childList: true, subtree: true }); | |
| observer.observe(quantityComponent, { childList: true, subtree: true }); // eslint-disable-line no-undef |
This change allows you to keep the code as is while silencing the linter warning. If the linter is indeed misconfigured, you may also want to review the ESLint settings to ensure that valid identifiers like "subtree" are recognized.
This comment was generated by an experimental AI tool.
| @@ -1,4 +1,5 @@ | |||
| import BasePage from './base-page'; | |||
| import {validateProductOptions} from './partials/validate-product-options'; | |||
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: Import path mush be a path alias
The issue described by the ESLint linter indicates that the import path for validateProductOptions is not using a path alias, which is likely a requirement set in the project's ESLint configuration. Path aliases help to simplify imports and make the codebase more maintainable by avoiding relative paths.
To fix this issue, you would need to replace the relative import path with the appropriate path alias defined in your project's configuration. Assuming the alias for the partials directory is set to @partials, the line can be modified as follows:
| import {validateProductOptions} from './partials/validate-product-options'; | |
| import {validateProductOptions} from '@partials/validate-product-options'; |
This comment was generated by an experimental AI tool.
| overlay.classList.add('loading-overlay', 'absolute', 'inset-0', 'z-50', 'flex', 'justify-center', 'items-center'); | ||
|
|
||
| const background = document.createElement('div'); | ||
| background.classList.add('absolute', 'inset-0', 'bg-white', 'opacity-40'); |
There was a problem hiding this comment.
❌ Codacy found a critical Error Prone issue: You have a misspelled word: bg on String
The issue identified by the ESLint linter indicates that the word "bg" in the class name "bg-white" is considered a misspelling. This is likely due to ESLint's dictionary not recognizing "bg" as a valid abbreviation for "background."
To resolve this issue, we can replace "bg-white" with "background-white" if that class exists in the CSS framework being used. However, if "bg-white" is indeed a valid class (for example, in Tailwind CSS), we might want to ignore this specific ESLint rule for this line instead.
Assuming "bg-white" is correct and we want to ignore the ESLint warning, here’s the code suggestion:
| background.classList.add('absolute', 'inset-0', 'bg-white', 'opacity-40'); | |
| background.classList.add('absolute', 'inset-0', 'bg-white', 'opacity-40'); // eslint-disable-line spelling/spell-checker |
If "bg-white" is not valid and we need to change it, it would be:
| background.classList.add('absolute', 'inset-0', 'bg-white', 'opacity-40'); | |
| background.classList.add('absolute', 'inset-0', 'background-white', 'opacity-40'); |
Please choose the appropriate suggestion based on your CSS framework.
This comment was generated by an experimental AI tool.
| @@ -1,4 +1,5 @@ | |||
| import BasePage from './base-page'; | |||
| import {validateProductOptions} from './partials/validate-product-options'; | |||
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected 'multiple' syntax before 'single' syntax.
| import {validateProductOptions} from './partials/validate-product-options'; | |
| import BasePage from './base-page'; |
| updateCartItemState(cartItems, currentProduct); | ||
| }) | ||
| .then(() => removeLoadingOverlay()) | ||
| .catch(error => { |
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected parentheses around arrow function argument.
| .catch(error => { | |
| .catch((error) => { |
| .getCurrentCartId(false, "salla-product-options") | ||
| .then((cartId) => salla.cart.details(cartId, ['options'])) | ||
| .then(({ data: { cart: cartDetails } }) => { | ||
| const currentProduct = cartDetails.items.find(item => Number(item.id) === Number(itemId)); |
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected parentheses around arrow function argument.
| const currentProduct = cartDetails.items.find(item => Number(item.id) === Number(itemId)); | |
| const currentProduct = cartDetails.items.find((item) => Number(item.id) === Number(itemId)); |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour? (You can also link to the ticket here)
Does this PR introduce a breaking change?
Screenshots (If appropriate)