Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new subtopic pattern for datamart directory structure change #305

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

douglatornell
Copy link
Member

@douglatornell douglatornell commented Nov 18, 2024

  • Updated hrdps-continental-dd-weather.conf to include a new subtopic pattern in anticipation of the 27-Nov-2024 4-Dec-2024 change in the directory structure on the dd.weather.gc.ca server.
  • The new pattern aligns with that of the hpfx.collab.science.gc.ca server to prevent any interruption during the transition.
  • After the directory structure change, the model_hrdps.continental.2.5km.# subtopic can be safely removed.

@douglatornell douglatornell added maintenance Codebase maintenance sarracenia Affects Sarracenia ECCC AMQP client labels Nov 18, 2024
@douglatornell douglatornell added this to the v24.2 milestone Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.72%. Comparing base (aec29e1) to head (4e3b6d9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   77.72%   77.72%           
=======================================
  Files         133      133           
  Lines       18778    18778           
  Branches      762      762           
=======================================
  Hits        14595    14595           
  Misses       4117     4117           
  Partials       66       66           
Flag Coverage Δ
unittests 77.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@douglatornell douglatornell changed the title Add new subtopic pattern for directory structure change Add new subtopic pattern for datamart directory structure change Nov 18, 2024
@douglatornell
Copy link
Member Author

Changed was postponed on 26-Nov-2024 by a week to 4-Dec-2024.

Include an additional subtopic pattern in anticipation of 27-Nov-2024 change
in the directory structure on the dd.weather.gc.ca server to match that of the
hpfx.collab.science.gc.ca server. This should ensure that there is no
interruption when the directory structure is changed. After the change the
`model_hrdps.continental.2.5km.#` can be removed.
Include an additional subtopic pattern re: of ~27-Nov-2024~ 4-Dec-2024 change
in the directory structure on the dd.weather.gc.ca server to match that of the
hpfx.collab.science.gc.ca server. After the change the
`model_hrdps.continental.2.5km.#` can be removed.
Drop subtopic patterns that were disabled by the 4-Dec-2024 change
in the directory structure on the dd.weather.gc.ca server to match that of the
hpfx.collab.science.gc.ca server.
dd.weather.gc.ca was unreliable after its directory structure was change to
match that of hpfx on 4-Dec-2024. So, we switched back to using hpfx and found
that there were none of the missing file messages and duplicated files issues
in HRDPS downloads that caused us to switch to dd.weather on 25-Apr-2023.
@douglatornell douglatornell merged commit c5f04e3 into main Dec 5, 2024
8 checks passed
@douglatornell douglatornell deleted the update-sarracenia branch December 5, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Codebase maintenance sarracenia Affects Sarracenia ECCC AMQP client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant