Update date parsing for river data collection #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the date_parser to date_format in collect_river_data.py to use ISO8601 date format. Updated corresponding unit test mock in test_collect_river_data.py for consistency. These changes were required due to deprecation of date_parser in pandas=2.0.0. re: issue #290
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
=======================================
Coverage 77.67% 77.68%
=======================================
Files 133 133
Lines 18733 18733
Branches 1910 1909 -1
=======================================
+ Hits 14551 14552 +1
Misses 4115 4115
+ Partials 67 66 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the date_parser to date_format in collect_river_data.py to use ISO8601 date format. Updated corresponding unit test mock in test_collect_river_data.py for consistency. These changes were required due to deprecation of date_parser in pandas=2.0.0.
re: issue #290