Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace warning suppression in crop_gribs worker #277

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

douglatornell
Copy link
Member

The 'warnings' module import and its associated catch-block have been removed from crop_gribs.py. Instead, a 'no_warn' argument has been added directly to the 'to_grib()' function call. This results in a cleaner, more efficient, and more direct way to suppress warnings within the specific context.

The 'warnings' module import and its associated catch-block have been removed
from crop_gribs.py. Instead, a 'no_warn' argument has been added directly to the
'to_grib()' function call. This results in a cleaner, more efficient, and more
direct way to suppress warnings within the specific context.
@douglatornell douglatornell added Workers maintenance Codebase maintenance labels Jun 19, 2024
@douglatornell douglatornell added this to the v24.2 milestone Jun 19, 2024
@douglatornell douglatornell merged commit f191688 into main Jun 19, 2024
6 checks passed
@douglatornell douglatornell deleted the xarray_to_grib-no_warn branch June 19, 2024 17:44
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.65%. Comparing base (1dc149f) to head (22281f1).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
nowcast/workers/crop_gribs.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   77.64%   77.65%           
=======================================
  Files         133      133           
  Lines       18698    18695    -3     
  Branches     1911     1910    -1     
=======================================
- Hits        14518    14517    -1     
+ Misses       4113     4111    -2     
  Partials       67       67           
Flag Coverage Δ
unittests 77.65% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Codebase maintenance Workers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant