Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update badge tables in README and dev docs #257

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

douglatornell
Copy link
Member

This change was necessitated by changes in the GitHub reStructuredText renderer that caused the tables to fail to render on github.com:

  • removed split in Meta cell
  • reduced spaces between cell separator and text to prevent addition of quoted text bars; it seems that GitHub is doing a reStructuredText to Markdown transformation in the rendering pipeline

Also updated the Python version badge to pull from pyproject.toml file so that there is one less change necessary when the Python version is changed.

This change was necessitated by changes in the GitHub reStructuredText renderer
that caused the tables to fail to render on github.com:
* removed split in Meta cell
* reduced spaces between cell separator and text to prevent addition of quoted
  text bars; it seems that GitHub is doing a reStructuredText to Markdown
  transformation in the rendering pipeline

Also updated the Python version badge to pull from `pyproject.toml` file so that
there is one less change necessary when the Python version is changed.
@douglatornell douglatornell added bug Something isn't working documentation Improvements or additions to documentation maintenance Codebase maintenance labels Apr 11, 2024
@douglatornell douglatornell added this to the v24.1 milestone Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.77%. Comparing base (1a88131) to head (3c1cde6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files         133      133           
  Lines       18822    18822           
  Branches     1914     1914           
=======================================
  Hits        14639    14639           
  Misses       4116     4116           
  Partials       67       67           
Flag Coverage Δ
unittests 77.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@douglatornell douglatornell merged commit 0ba03de into main Apr 11, 2024
8 checks passed
@douglatornell douglatornell deleted the fix-badge-tables branch April 11, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation maintenance Codebase maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant